Skip to content

feat!: #[utility] function#13243

Merged
benesjan merged 11 commits intomasterfrom
04-02-feat_utility_function
Apr 3, 2025
Merged

feat!: #[utility] function#13243
benesjan merged 11 commits intomasterfrom
04-02-feat_utility_function

Conversation

@benesjan
Copy link
Copy Markdown
Contributor

@benesjan benesjan commented Apr 2, 2025 •
edited
Loading

Partially addresses #12743 (partially as the rest will be addressed in PRs up the stacks)

Introduces a #[utility] macro for top-level unconstrained functions and applies it to all the relevant functions.

@benesjan Graphite App
Copy link
Copy Markdown
Contributor Author

benesjan commented Apr 2, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@benesjan benesjan changed the title feat: utility function feat!: #[utility] function Apr 2, 2025
@benesjan benesjan force-pushed the 04-02-feat_utility_function branch 2 times, most recently from 69eb040 to 27a7b8b Compare April 2, 2025 18:24
benesjan
benesjan commented Apr 2, 2025
View reviewed changes
noir-projects/aztec-nr/aztec/src/macros/functions/utils.nr

pub(crate) comptime fn transform_top_level_unconstrained(f: FunctionDefinition) {
// Create utility context
let context_creation = quote { let mut context = dep::aztec::context::unconstrained_context::UnconstrainedContext::new(); };
Copy link
Copy Markdown
Contributor Author

@benesjan benesjan Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will rename UnconstrainedContext in a PR up the stack.

@benesjan benesjan marked this pull request as ready for review April 2, 2025 19:29
@benesjan benesjan mentioned this pull request Apr 2, 2025
Merged
@benesjan benesjan force-pushed the 04-02-feat_utility_function branch from 9e5bd02 to 38d59b2 Compare April 2, 2025 20:05
This was referenced Apr 2, 2025
Closed
Merged
@benesjan benesjan changed the base branch from master to graphite-base/13243 April 2, 2025 22:06
@benesjan benesjan force-pushed the 04-02-feat_utility_function branch from 38d59b2 to 0d312a9 Compare April 2, 2025 22:06
@benesjan benesjan changed the base branch from graphite-base/13243 to 04-02-chore_minor_simulator_utils_cleanup April 2, 2025 22:06
@benesjan benesjan mentioned this pull request Apr 2, 2025
Merged
@benesjan benesjan changed the base branch from 04-02-chore_minor_simulator_utils_cleanup to graphite-base/13243 April 2, 2025 23:53
@benesjan benesjan force-pushed the 04-02-feat_utility_function branch from 0d312a9 to 5fdc5fc Compare April 2, 2025 23:53
@benesjan benesjan force-pushed the graphite-base/13243 branch from 1a7a6c2 to 84890c2 Compare April 2, 2025 23:53
@benesjan benesjan changed the base branch from graphite-base/13243 to master April 2, 2025 23:54
@benesjan benesjan force-pushed the 04-02-feat_utility_function branch from 5fdc5fc to 61a1885 Compare April 2, 2025 23:54
@benesjan benesjan requested a review from nventuro April 3, 2025 02:35
benesjan
benesjan commented Apr 3, 2025
View reviewed changes
noir-projects/aztec-nr/aztec/src/macros/aztec.nr Outdated

/// Marks a contract as an Aztec contract, generating the interfaces for its functions and notes, as well as injecting
/// the `process_log` and `sync_notes` functions PXE requires in order to discover notes.
/// the `sync_notes` function PXE requires in order to discover notes.
Copy link
Copy Markdown
Contributor Author

@benesjan benesjan Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These docs were stale and I forgot to update them when streamlining the log processing.

@benesjan benesjan force-pushed the 04-02-feat_utility_function branch from 19530b9 to 986418b Compare April 3, 2025 15:34
@benesjan benesjan requested a review from sklppy88 April 3, 2025 19:23
nventuro
nventuro approved these changes Apr 3, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@nventuro nventuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally!

@benesjan benesjan mentioned this pull request Apr 3, 2025
Merged
@benesjan benesjan force-pushed the 04-02-feat_utility_function branch 2 times, most recently from cfe32dc to 569919f Compare April 3, 2025 20:29
@benesjan benesjan enabled auto-merge April 3, 2025 20:36
@benesjan benesjan force-pushed the 04-02-feat_utility_function branch from 569919f to c1c0e74 Compare April 3, 2025 22:50
@benesjan benesjan added this pull request to the merge queue Apr 3, 2025
Merged via the queue into master with commit 945ffa2 Apr 3, 2025
8 checks passed
@benesjan benesjan deleted the 04-02-feat_utility_function branch April 3, 2025 23:43
@AztecBot AztecBot mentioned this pull request Apr 3, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Apr 4, 2025
@AztecBot
chore(master): release 0.84.0 (#13267)
9165027 
🤖 I have created a new Aztec Packages release
---


##
[0.84.0](v0.83.1...v0.84.0)
(2025-04-04)


### ⚠ BREAKING CHANGES

* `UnsconstrainedContext` --> `UtilityContext`
([#13246](#13246))
* `#[utility]` function
([#13243](#13243))
* Validate public setup fns and gas in p2p
([#13154](#13154))

### Features

* `#[utility]` function
([#13243](#13243))
([945ffa2](945ffa2))
* **avm:** tx hint init
([#13218](#13218))
([60a1a92](60a1a92))
* Remove 4 byte metadata from bb-produced proof
([#13231](#13231))
([0dcc915](0dcc915))
* To enable better ci dashboard.
([#13272](#13272))
([61c6375](61c6375))


### Bug Fixes

* **avm:** fix lookup builder and FF hashing
([#13263](#13263))
([2633856](2633856))
* ci3-external concurrency bug, reduce grind set
([2c5e830](2c5e830)),
closes
[#13285](#13285)
* ci3-external.yml
([#13291](#13291))
([6ad68ed](6ad68ed))
* Validate public setup fns and gas in p2p
([#13154](#13154))
([1ef4add](1ef4add)),
closes
[#10958](#10958)


### Miscellaneous

* `UnsconstrainedContext` --> `UtilityContext`
([#13246](#13246))
([69df86f](69df86f))
* add some PrivateSet tests
([#13270](#13270))
([bd9e690](bd9e690))
* bump full prover test to 32 cores. hoping to boost speed.
([#13293](#13293))
([c8e95dd](c8e95dd))
* deflake p2p reqresp test
([#13271](#13271))
([b9164fa](b9164fa))
* don't dump on fail. click the link instead.
([#13292](#13292))
([ba0fb4d](ba0fb4d))
* flake
([#13277](#13277))
([62c32eb](62c32eb))
* make rahul happy with migration notes
([#13255](#13255))
([3dd75a6](3dd75a6))
* minor simulator utils cleanup
([#13250](#13250))
([8a622c9](8a622c9))
* move a couple of `SharedMutableValues` functions outside of impl
([#13283](#13283))
([df9a40c](df9a40c))
* nuking debug-only logger and various unused functionality in
`foundation`
([#13187](#13187))
([2d38e60](2d38e60))
* prevent eth devnet config contention in ci
([#13260](#13260))
([1581836](1581836))
* renaming unconstrained function as utility in TS
([#13249](#13249))
([34d03bb](34d03bb))
* replace relative paths to noir-protocol-circuits
([b5b99f8](b5b99f8))
* Speed up note hashes test
([#13282](#13282))
([ad23358](ad23358))
* update gov and proposer configs
([#13281](#13281))
([e1a5be3](e1a5be3))
* update slashing test port
([#13274](#13274))
([9a1ddc5](9a1ddc5))
* Want to fail fast on test runs and the wider ci run.
([#13258](#13258))
([f0553b8](f0553b8))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@nventuro nventuro mentioned this pull request Apr 4, 2025
Merged
github-merge-queue bot pushed a commit that referenced this pull request Apr 4, 2025
@nventuro
fix: remove second msg discovery call in sync_notes (#13328)
8dcebac 
When the `#[utility]` macro was added to `sync_notes` in #13243, we
didn't realize that by applying the macro to `sync_notes` we were
causing for message discovery to be invoked _again_, since that's what
the macro does. `sync_notes` can now be an empty function.
@nventuro nventuro mentioned this pull request Apr 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nventuro nventuro nventuro approved these changes

@sklppy88 sklppy88 Awaiting requested review from sklppy88

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benesjan @nventuro