refactor: remove 'pub' visibility from utility function return types

Author: benesjan

boxes/boxes/react/src/contracts/src/main.nr

@@ -40,7 +40,7 @@ contract BoxReact {
     }
 
     #[utility]
-    unconstrained fn getNumber(owner: AztecAddress) -> pub ValueNote {
+    unconstrained fn getNumber(owner: AztecAddress) -> ValueNote {
         let numbers = storage.numbers;
         numbers.at(owner).view_note()
     }

boxes/boxes/vanilla/src/contracts/src/main.nr

@@ -40,7 +40,7 @@ contract Vanilla {
     }
 
     #[utility]
-    unconstrained fn getNumber(owner: AztecAddress) -> pub ValueNote {
+    unconstrained fn getNumber(owner: AztecAddress) -> ValueNote {
         let numbers = storage.numbers;
         numbers.at(owner).view_note()
     }

boxes/boxes/vite/src/contracts/src/main.nr

@@ -40,7 +40,7 @@ contract BoxReact {
     }
 
     #[utility]
-    unconstrained fn getNumber(owner: AztecAddress) -> pub ValueNote {
+    unconstrained fn getNumber(owner: AztecAddress) -> ValueNote {
         let numbers = storage.numbers;
         numbers.at(owner).view_note()
     }

docs/docs/migration_notes.md

@@ -6,7 +6,7 @@ keywords: [sandbox, aztec, notes, migration, updating, upgrading]
 
 Aztec is in full-speed development. Literally every version breaks compatibility with the previous ones. This page attempts to target errors and difficulties you might encounter when upgrading, and how to resolve them.
 
-## 0.83.0
+## TBD
 
 ### [Aztec.nr] #[utility] functions
 
@@ -20,11 +20,13 @@ For this reason you need to apply #[utility] macro to functions which were origi
 
 ```diff
 +    #[utility]
-    unconstrained fn balance_of_private(owner: AztecAddress) -> pub u128 {
+    unconstrained fn balance_of_private(owner: AztecAddress) -> u128 {
         storage.balances.at(owner).balance_of()
     }
 ```
 
+## 0.83.0
+
 ### [aztec.js] AztecNode.getPrivateEvents API change
 
 The `getPrivateEvents` method signature has changed to require an address of a contract that emitted the event and use recipient addresses instead of viewing public keys:

noir-projects/noir-contracts/contracts/app_subscription_contract/src/main.nr

@@ -116,7 +116,7 @@ pub contract AppSubscription {
     }
 
     #[utility]
-    unconstrained fn is_initialized(subscriber: AztecAddress) -> pub bool {
+    unconstrained fn is_initialized(subscriber: AztecAddress) -> bool {
         storage.subscriptions.at(subscriber).is_initialized()
     }
 }

noir-projects/noir-contracts/contracts/auth_registry_contract/src/main.nr

@@ -132,7 +132,7 @@ pub contract AuthRegistry {
     unconstrained fn unconstrained_is_consumable(
         on_behalf_of: AztecAddress,
         message_hash: Field,
-    ) -> pub bool {
+    ) -> bool {
         storage.approved_actions.at(on_behalf_of).at(message_hash).read()
     }
 }

noir-projects/noir-contracts/contracts/card_game_contract/src/main.nr

@@ -138,7 +138,7 @@ pub contract CardGame {
     unconstrained fn view_collection_cards(
         owner: AztecAddress,
         offset: u32,
-    ) -> pub BoundedVec<Card, MAX_NOTES_PER_PAGE> {
+    ) -> BoundedVec<Card, MAX_NOTES_PER_PAGE> {
         let collection = storage.collections.at(owner);
         collection.view_cards(offset)
     }
@@ -148,14 +148,14 @@ pub contract CardGame {
         game: u32,
         player: AztecAddress,
         offset: u32,
-    ) -> pub BoundedVec<Card, MAX_NOTES_PER_PAGE> {
+    ) -> BoundedVec<Card, MAX_NOTES_PER_PAGE> {
         let game_deck = storage.game_decks.at(game as Field).at(player);
 
         game_deck.view_cards(offset)
     }
 
     #[utility]
-    unconstrained fn view_game(game: u32) -> pub Game {
+    unconstrained fn view_game(game: u32) -> Game {
         storage.games.at(game as Field).read()
     }
 }

noir-projects/noir-contracts/contracts/counter_contract/src/main.nr

@@ -84,7 +84,7 @@ pub contract Counter {
 
     // docs:start:get_counter
     #[utility]
-    unconstrained fn get_counter(owner: AztecAddress) -> pub Field {
+    unconstrained fn get_counter(owner: AztecAddress) -> Field {
         let counters = storage.counters;
         balance_utils::get_balance(counters.at(owner).set)
     }

noir-projects/noir-contracts/contracts/easy_private_token_contract/src/main.nr

@@ -43,7 +43,7 @@ pub contract EasyPrivateToken {
 
     // Helper function to get the balance of a user.
     #[utility]
-    unconstrained fn get_balance(owner: AztecAddress) -> pub Field {
+    unconstrained fn get_balance(owner: AztecAddress) -> Field {
         let balances = storage.balances;
 
         // Return the sum of all notes in the set.

noir-projects/noir-contracts/contracts/easy_private_voting_contract/src/main.nr

@@ -69,7 +69,7 @@ pub contract EasyPrivateVoting {
     // docs:end:end_vote
     // docs:start:get_vote
     #[utility]
-    unconstrained fn get_vote(candidate: Field) -> pub Field {
+    unconstrained fn get_vote(candidate: Field) -> Field {
         storage.tally.at(candidate).read()
     }
     // docs:end:get_vote