feat: use msgpack for ClientIvc::Proof in API by ledwards2225 · Pull Request #12911 · AztecProtocol/aztec-packages

ledwards2225 · 2025-03-20T15:53:40Z

Switches to using msgpack for serialization/deserialization of a ClientIVC::Proof, instead of our custom serialization lib.

This was motivated by the desire to gracefully handle (reject) invalid proof buffers (in the form of fully random bytes) in native verification. Our custom serialization library is not meant to handle a fully random buffer because it relies on 4-byte chunks containing size data that indicate how much to read from an address. When the size bytes are corrupted, the code may attempt to read into uninitialized memory. Msgpack on the other hand will throw a meaningful and consistent error when the proof structure is not as expected. This results in verification failure by default.

Note: if the proof has valid structure but is not itself valid, verification will proceed as normal and return failure in a time less than or equal to that required for successful verification.

…ck_civc_proof

ledwards2225 · 2025-03-21T18:51:20Z

Quick rejection (see timestamp)

23:29:48.829] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x152e9fbebfab6f7292bb62675b2e23b7369981075e67969cb7b9bac1ad624ab1: Error: Failed to verify ClientIVC proof!
[23:29:48.829] WARN: p2p:tx_validator:private_proof Rejecting tx 0x152e9fbebfab6f7292bb62675b2e23b7369981075e67969cb7b9bac1ad624ab1 for invalid proof
[23:29:48.830] WARN: node Invalid tx 0x152e9fbebfab6f7292bb62675b2e23b7369981075e67969cb7b9bac1ad624ab1: Invalid proof {"txHash":"0x152e9fbebfab6f7292bb62675b2e23b7369981075e67969cb7b9bac1ad624ab1"}
[23:29:48.946] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x0241f572913ac9b4e1f8c47d89dd8e9047e03884b411e31aac36f26bd1d0ab3e: Error: Failed to verify ClientIVC proof!
[23:29:48.947] WARN: p2p:tx_validator:private_proof Rejecting tx 0x0241f572913ac9b4e1f8c47d89dd8e9047e03884b411e31aac36f26bd1d0ab3e for invalid proof
[23:29:48.947] WARN: node Invalid tx 0x0241f572913ac9b4e1f8c47d89dd8e9047e03884b411e31aac36f26bd1d0ab3e: Invalid proof {"txHash":"0x0241f57
 RUNS  src/e2e_prover/full.test.ts
 RUNS  src/e2e_prover/full.test.ts
 RUNS  src/e2e_prover/full.test.ts
[23:30:16.077] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x130f285ebfa55d20e90e82f15c076065c4efb31e1f7d0d667ba766cf1d23cde4: Error: Failed to verify ClientIVC proof!
[23:30:16.077] WARN: p2p:tx_validator:private_proof Rejecting tx 0x130f285ebfa55d20e90e82f15c076065c4efb31e1f7d0d667ba766cf1d23cde4 for invalid proof
[23:30:16.077] WARN: node Invalid tx 0x130f285ebfa55d20e90e82f15c076065c4efb31e1f7d0d667ba766cf1d23cde4: Invalid proof {"txHash":"0x130f285ebfa55d20e90e82f15c076065c4efb31e1f7d0d667ba766cf1d23cde4"}
[23:30:16.196] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x19467a69668882a67f8b34529772c262d9c5e068c89b08a4992bdc41c9c59a5f: Error: Failed to verify ClientIVC proof!
[23:30:16.196] WARN: p2p:tx_validator:private_proof Rejecting tx 0x19467a69668882a67f8b34529772c262d9c5e068c89b08a4992bdc41c9c59a5f for invalid proof
[23:30:16.196] WARN: node Invalid tx 0x19467a69668882a67f8b34529772c262d9c5e068c89b08a4992bdc41c9c59a5f: Invalid proof {"txHash":"0x19467a69668882a67f8b34529772c262d9c5e068c89b08a4992bdc41c9c59a5f"}
[23:30:16.308] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x2aeb7be45d230bb574f94222b0894d72f1adef43e46eae072e48b8e75bf43238: Error: Failed to verify ClientIVC proof!
[23:30:16.308] WARN: p2p:tx_validator:private_proof Rejecting tx 0x2aeb7be45d230bb574f94222b0894d72f1adef43e46eae072e48b8e75bf43238 for invalid proof
[23:30:16.309] WARN: node Invalid tx 0x2aeb7be45d230bb574f94222b0894d72f1adef43e46eae072e48b8e75bf43238: Invalid proof {"txHash":"0x2aeb7be45d230bb574f94222b0894d72f1adef43e46eae072e48b8e75bf43238"}
[23:30:16.420] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x0939196348a3432e397f44847145b57ab0c561cbee7e21e6efbe1ab5ee72df4f: Error: Failed to verify ClientIVC proof!
[23:30:16.420] WARN: p2p:tx_validator:private_proof Rejecting tx 0x0939196348a3432e397f44847145b57ab0c561cbee7e21e6efbe1ab5ee72df4f for invalid proof
[23:30:16.420] WARN: node Invalid tx 0x0939196348a3432e397f44847145b57ab0c561cbee7e21e6efbe1ab5ee72df4f: Invalid proof {"txHash":"0x0939196348a3432e397f44847145b57ab0c561cbee7e21e6efbe1ab5ee72df4f"}
[23:30:16.528] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x22817757058b03a3f39be2f0b9af339ec11f67a738bac0d045477745adf95d23: Error: Failed to verify ClientIVC proof!
[23:30:16.528] WARN: p2p:tx_validator:private_proof Rejecting tx 0x22817757058b03a3f39be2f0b9af339ec11f67a738bac0d045477745adf95d23 for invalid proof
[23:30:16.528] WARN: node Invalid tx 0x22817757058b03a3f39be2f0b9af339ec11f67a738bac0d045477745adf95d23: Invalid proof {"txHash":"0x22817757058b03a3f39be2f0b9af339ec11f67a738bac0d045477745adf95d23"}
[23:30:16.636] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x000a54ba265f74b107d638bf99cc90606d0de0564a5366e45643b8152f88b6a9: Error: Failed to verify ClientIVC proof!
[23:30:16.636] WARN: p2p:tx_validator:private_proof Rejecting tx 0x000a54ba265f74b107d638bf99cc90606d0de0564a5366e45643b8152f88b6a9 for invalid proof
[23:30:16.637] WARN: node Invalid tx 0x000a54ba265f74b107d638bf99cc90606d0de0564a5366e45643b8152f88b6a9: Invalid proof {"txHash":"0x000a54ba265f74b107d638bf99cc90606d0de0564a5366e45643b8152f88b6a9"}
[23:30:16.748] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x00be947878ade7828cbba34e4c9ad536e179fb7431a912cd8f38962f34a67dc3: Error: Failed to verify ClientIVC proof!
[23:30:16.748] WARN: p2p:tx_validator:private_proof Rejecting tx 0x00be947878ade7828cbba34e4c9ad536e179fb7431a912cd8f38962f34a67dc3 for invalid proof
[23:30:16.749] WARN: node Invalid tx 0x00be947878ade7828cbba34e4c9ad536e179fb7431a912cd8f38962f34a67dc3: Invalid proof {"txHash":"0x00be947878ade7828cbba34e4c9ad536e179fb7431a912cd8f38962f34a67dc3"}
[23:30:16.868] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x0020ffbca1ee943b110fa7585bc40231f4db7fc688afcca136eccd3e3985047e: Error: Failed to verify ClientIVC proof!
[23:30:16.869] WARN: p2p:tx_validator:private_proof Rejecting tx 0x0020ffbca1ee943b110fa7585bc40231f4db7fc688afcca136eccd3e3985047e for invalid proof
[23:30:16.869] WARN: node Invalid tx 0x0020ffbca1ee943b110fa7585bc40231f4db7fc688afcca136eccd3e3985047e: Invalid proof {"txHash":"0x0020ffbca1ee943b110fa7585bc40231f4db7fc688afcca136eccd3e3985047e"}
[23:30:16.985] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x0f8463b341c4b05b5a444f339c50e1538f72470db449f5b32551b0abeff16524: Error: Failed to verify ClientIVC proof!
[23:30:16.986] WARN: p2p:tx_validator:private_proof Rejecting tx 0x0f8463b341c4b05b5a444f339c50e1538f72470db449f5b32551b0abeff16524 for invalid proof
[23:30:16.986] WARN: node Invalid tx 0x0f8463b341c4b05b5a444f339c50e1538f72470db449f5b32551b0abeff16524: Invalid proof {"txHash":"0x0f8463b
 RUNS  src/e2e_prover/full.test.ts
[23:30:17.102] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x0f5b0bd9f2d98be80e331cf96951bffb509f17f8db62d7037b27f0befaae2ddf: Error: Failed to verify ClientIVC proof!
[23:30:17.102] WARN: p2p:tx_validator:private_proof Rejecting tx 0x0f5b0bd9f2d98be80e331cf96951bffb509f17f8db62d7037b27f0befaae2ddf for invalid proof
[23:30:17.102] WARN: node Invalid tx 0x0f5b0bd9f2d98be80e331cf96951bffb509f17f8db62d7037b27f0befaae2ddf: Invalid proof {"txHash":"0x0f5b0bd9f2d98be80e331cf96951bffb509f17f8db62d7037b27f0befaae2ddf"}
[23:30:17.209] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x175b9376bc5f0a60943d178e60e080c059a0730bae55d4c96f8c25614923ba79: Error: Failed to verify ClientIVC proof!
[23:30:17.210] WARN: p2p:tx_validator:private_proof Rejecting tx 0x175b9376bc5f0a60943d178e60e080c059a0730bae55d4c96f8c25614923ba79 for invalid proof
[23:30:17.210] WARN: node Invalid tx 0x175b9376bc5f0a60943d178e60e080c059a0730bae55d4c96f8c25614923ba79: Invalid proof {"txHash":"0x175b9376bc5f0a60943d178e60e080c059a0730bae55d4c96f8c25614923ba79"}
[23:30:17.323] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x0fc5729d1f9843bb1af6f32977db99e262e5fee1f44a1f1fd63cdcddbc13b9eb: Error: Failed to verify ClientIVC proof!
[23:30:17.323] WARN: p2p:tx_validator:private_proof Rejecting tx 0x0fc5729d1f9843bb1af6f32977db99e262e5fee1f44a1f1fd63cdcddbc13b9eb for invalid proof
[23:30:17.324] WARN: node Invalid tx 0x0fc5729d1f9843bb1af6f32977db99e262e5fee1f44a1f1fd63cdcddbc13b9eb: Invalid proof {"txHash":"0x0fc5729d1f9843bb1af6f32977db99e262e5fee1f44a1f1fd63cdcddbc13b9eb"}
[23:30:17.435] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x0b2271a9ae5775a1d9f3d27be6aa02191d0c41a939d654226dffe1ad9f0fb172: Error: Failed to verify ClientIVC proof!
[23:30:17.435] WARN: p2p:tx_validator:private_proof Rejecting tx 0x0b2271a9ae5775a1d9f3d27be6aa02191d0c41a939d654226dffe1ad9f0fb172 for invalid proof
[23:30:17.435] WARN: node Invalid tx 0x0b2271a9ae5775a1d9f3d27be6aa02191d0c41a939d654226dffe1ad9f0fb172: Invalid proof {"txHash":"0x0b2271a9ae5775a1d9f3d27be6aa02191d0c41a939d654226dffe1ad9f0fb172"}
[23:30:17.544] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x1e512b9739e947149bfe9c643ba30caf862d64cd00371fbb5e8d3827a4c4edce: Error: Failed to verify ClientIVC proof!
[23:30:17.545] WARN: p2p:tx_validator:private_proof Rejecting tx 0x1e512b9739e947149bfe9c643ba30caf862d64cd00371fbb5e8d3827a4c4edce for invalid proof
[23:30:17.545] WARN: node Invalid tx 0x1e512b9739e947149bfe9c643ba30caf862d64cd00371fbb5e8d3827a4c4edce: Invalid proof {"txHash":"0x1e512b9739e947149bfe9c643ba30caf862d64cd00371fbb5e8d3827a4c4edce"}
[23:30:17.660] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x1f7509fdffc0532ebfce2e8af9f8dc3d8681b517200b0367037e04a1cad20012: Error: Failed to verify ClientIVC proof!
[23:30:17.661] WARN: p2p:tx_validator:private_proof Rejecting tx 0x1f7509fdffc0532ebfce2e8af9f8dc3d8681b517200b0367037e04a1cad20012 for invalid proof
[23:30:17.661] WARN: node Invalid tx 0x1f7509fdffc0532ebfce2e8af9f8dc3d8681b517200b0367037e04a1cad20012: Invalid proof {"txHash":"0x1f7509fdffc0532ebfce2e8af9f8dc3d8681b517200b0367037e04a1cad20012"}
[23:30:17.771] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x20ba20d767001f4e54ee23faac1443cca6e6e84df7ce4d5926e572dea5ed8fb7: Error: Failed to verify ClientIVC proof!
[23:30:17.772] WARN: p2p:tx_validator:private_proof Rejecting tx 0x20ba20d767001f4e54ee23faac1443cca6e6e84df7ce4d5926e572dea5ed8fb7 for invalid proof
[23:30:17.772] WARN: node Invalid tx 0x20ba20d767001f4e54ee23faac1443cca6e6e84df7ce4d5926e572dea5ed8fb7: Invalid proof {"txHash":"0x20ba20d767001f4e54ee23faac1443cca6e6e84df7ce4d5926e572dea5ed8fb7"}
[23:30:17.890] WARN: bb-prover:verifier Failed to verify ClientIVC proof for tx 0x0952fb7f6d9d38b0f6fcdbee7f0a781e65b3eef53740567790c699b0529ee289: Error: Failed to verify ClientIVC proof!
[23:30:17.890] WARN: p2p:tx_validator:private_proof Rejecting tx 0x0952fb7f6d9d38b0f6fcdbee7f0a781e65b3eef53740567790c699b0529ee289 for invalid proof
[23:30:17.890] WARN: node Invalid tx 0x0952fb7f6d9d38b0f6fcdbee7f0a781e65b3eef53740567790c699b0529ee289: Invalid proof {"txHash":"0x0952fb7f6d9d38b0f6fcdbee7f0a781e65b3eef53740567790c699b0529ee289"}

ludamad · 2025-03-22T21:03:54Z

barretenberg/cpp/src/barretenberg/client_ivc/client_ivc.hpp

+            msgpack::sbuffer buffer;
+            msgpack::pack(buffer, *this);
+            return buffer;
+        }


Suspect that this didn't add any new headers (but also in general this should be in a cpp file as msgpack stuff that isn't our thin header include should avoid header pollution)

yeah I definitely don't want this in here. When you're back we should discuss how to standardize things, assuming we move to more msgpack use in general. I saw you had some established patterns using msgpack::packer - maybe this can just fit into that but wasn't sure it was the right thing

🤖 I have created a new Aztec Packages release --- ## [0.82.1](v0.82.0...v0.82.1) (2025-03-24) ### Features * **avm:** Port field gt to vm2 ([#12883](#12883)) ([0ae6891](0ae6891)) * use msgpack for ClientIvc::Proof in API ([#12911](#12911)) ([1a01602](1a01602)) ### Bug Fixes * disable proving on vite box ([#12971](#12971)) ([69a0fb6](69a0fb6)) * no hardcoded versions in bbup ([#12944](#12944)) ([397144f](397144f)) * pull CRS data ahead of time ([#12945](#12945)) ([43155d6](43155d6)) * Remove workaround ([#12952](#12952)) ([c3337af](c3337af)) * set the correct env var ([#12959](#12959)) ([bd0f4b2](bd0f4b2)) * yolo add bunch of test flakes ([13c19da](13c19da)) * yolo e2e_p2p tests now fully skipped due to huge speed regression ([9141410](9141410)) * yolo txe binds just to localhost by default. ([3933b35](3933b35)) ### Miscellaneous * Change `/bin/bash` shebang to be env based ([#12834](#12834)) ([7843a67](7843a67)) * clean up avm codeowners ([#12860](#12860)) ([35a8f46](35a8f46)) * deflake the kind smoke test ([#12955](#12955)) ([1a37d6d](1a37d6d)), closes [#11177](#11177) * fee cleanup ([#12941](#12941)) ([fdf1da4](fdf1da4)) * Increase bot count ([#12963](#12963)) ([16edd06](16edd06)) * L2 chain config for alpha testnet ([#12962](#12962)) ([e13edb8](e13edb8)) * Reduce bots ([#12953](#12953)) ([4bbc5da](4bbc5da)) * remove selector from public call request ([#12828](#12828)) ([18bcc1b](18bcc1b)) * replace relative paths to noir-protocol-circuits ([61cf4b6](61cf4b6)) * replace relative paths to noir-protocol-circuits ([4356c17](4356c17)) * replace relative paths to noir-protocol-circuits ([f73f47d](f73f47d)) * Set default proving config to true ([#12964](#12964)) ([75c1549](75c1549)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Switches to using msgpack for serialization/deserialization of a ClientIVC::Proof, instead of our custom serialization lib. This was motivated by the desire to gracefully handle (reject) invalid proof buffers (in the form of fully random bytes) in native verification. Our custom serialization library is not meant to handle a fully random buffer because it relies on 4-byte chunks containing size data that indicate how much to read from an address. When the size bytes are corrupted, the code may attempt to read into uninitialized memory. Msgpack on the other hand will throw a meaningful and consistent error when the proof structure is not as expected. This results in verification failure by default. Note: if the proof has valid structure but is not itself valid, verification will proceed as normal and return failure in a time less than or equal to that required for successful verification. --------- Co-authored-by: PhilWindle <[email protected]> Co-authored-by: cody <[email protected]>

🤖 I have created a new Aztec Packages release --- ## [0.82.1](v0.82.0...v0.82.1) (2025-03-24) ### Features * **avm:** Port field gt to vm2 ([#12883](#12883)) ([0ae6891](0ae6891)) * use msgpack for ClientIvc::Proof in API ([#12911](#12911)) ([1a01602](1a01602)) ### Bug Fixes * disable proving on vite box ([#12971](#12971)) ([69a0fb6](69a0fb6)) * no hardcoded versions in bbup ([#12944](#12944)) ([397144f](397144f)) * pull CRS data ahead of time ([#12945](#12945)) ([43155d6](43155d6)) * Remove workaround ([#12952](#12952)) ([c3337af](c3337af)) * set the correct env var ([#12959](#12959)) ([bd0f4b2](bd0f4b2)) * yolo add bunch of test flakes ([13c19da](13c19da)) * yolo e2e_p2p tests now fully skipped due to huge speed regression ([9141410](9141410)) * yolo txe binds just to localhost by default. ([3933b35](3933b35)) ### Miscellaneous * Change `/bin/bash` shebang to be env based ([#12834](#12834)) ([7843a67](7843a67)) * clean up avm codeowners ([#12860](#12860)) ([35a8f46](35a8f46)) * deflake the kind smoke test ([#12955](#12955)) ([1a37d6d](1a37d6d)), closes [#11177](#11177) * fee cleanup ([#12941](#12941)) ([fdf1da4](fdf1da4)) * Increase bot count ([#12963](#12963)) ([16edd06](16edd06)) * L2 chain config for alpha testnet ([#12962](#12962)) ([e13edb8](e13edb8)) * Reduce bots ([#12953](#12953)) ([4bbc5da](4bbc5da)) * remove selector from public call request ([#12828](#12828)) ([18bcc1b](18bcc1b)) * replace relative paths to noir-protocol-circuits ([61cf4b6](61cf4b6)) * replace relative paths to noir-protocol-circuits ([4356c17](4356c17)) * replace relative paths to noir-protocol-circuits ([f73f47d](f73f47d)) * Set default proving config to true ([#12964](#12964)) ([75c1549](75c1549)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

Switches to using msgpack for serialization/deserialization of a ClientIVC::Proof, instead of our custom serialization lib. This was motivated by the desire to gracefully handle (reject) invalid proof buffers (in the form of fully random bytes) in native verification. Our custom serialization library is not meant to handle a fully random buffer because it relies on 4-byte chunks containing size data that indicate how much to read from an address. When the size bytes are corrupted, the code may attempt to read into uninitialized memory. Msgpack on the other hand will throw a meaningful and consistent error when the proof structure is not as expected. This results in verification failure by default. Note: if the proof has valid structure but is not itself valid, verification will proceed as normal and return failure in a time less than or equal to that required for successful verification. --------- Co-authored-by: PhilWindle <[email protected]> Co-authored-by: cody <[email protected]>

🤖 I have created a new Aztec Packages release --- ## [0.82.1](v0.82.0...v0.82.1) (2025-03-24) ### Features * **avm:** Port field gt to vm2 ([#12883](#12883)) ([0ae6891](0ae6891)) * use msgpack for ClientIvc::Proof in API ([#12911](#12911)) ([1a01602](1a01602)) ### Bug Fixes * disable proving on vite box ([#12971](#12971)) ([69a0fb6](69a0fb6)) * no hardcoded versions in bbup ([#12944](#12944)) ([397144f](397144f)) * pull CRS data ahead of time ([#12945](#12945)) ([43155d6](43155d6)) * Remove workaround ([#12952](#12952)) ([c3337af](c3337af)) * set the correct env var ([#12959](#12959)) ([bd0f4b2](bd0f4b2)) * yolo add bunch of test flakes ([13c19da](13c19da)) * yolo e2e_p2p tests now fully skipped due to huge speed regression ([9141410](9141410)) * yolo txe binds just to localhost by default. ([3933b35](3933b35)) ### Miscellaneous * Change `/bin/bash` shebang to be env based ([#12834](#12834)) ([7843a67](7843a67)) * clean up avm codeowners ([#12860](#12860)) ([35a8f46](35a8f46)) * deflake the kind smoke test ([#12955](#12955)) ([1a37d6d](1a37d6d)), closes [#11177](#11177) * fee cleanup ([#12941](#12941)) ([fdf1da4](fdf1da4)) * Increase bot count ([#12963](#12963)) ([16edd06](16edd06)) * L2 chain config for alpha testnet ([#12962](#12962)) ([e13edb8](e13edb8)) * Reduce bots ([#12953](#12953)) ([4bbc5da](4bbc5da)) * remove selector from public call request ([#12828](#12828)) ([18bcc1b](18bcc1b)) * replace relative paths to noir-protocol-circuits ([61cf4b6](61cf4b6)) * replace relative paths to noir-protocol-circuits ([4356c17](4356c17)) * replace relative paths to noir-protocol-circuits ([f73f47d](f73f47d)) * Set default proving config to true ([#12964](#12964)) ([75c1549](75c1549)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

ledwards2225 added 5 commits March 19, 2025 15:08

WiP experiemnt w msgpack for civc proof

ca0ef02

write and read from file in test

ccd4932

encapsulte msgpak boilerplate in methods; need a better home

2ecc4c1

Merge branch 'master' into lde/msgpck_civc_proof

971ed35

clarify some things with coments

64e41a7

ledwards2225 self-assigned this Mar 20, 2025

PhilWindle and others added 3 commits March 20, 2025 19:10

Phil's example

e27b007

Throw something

adfbe18

Failure time goes from 21s to instantaneous

36bc543

ledwards2225 marked this pull request as ready for review March 20, 2025 20:56

Try success full test

3580c76

codygunton added the ci-full Run all master checks. label Mar 20, 2025

codygunton and others added 11 commits March 20, 2025 22:56

Merge commit '5b064bcc6eb347dd53ad3870fe0486792d2f79bb' into lde/msgp…

a484f5b

…ck_civc_proof

Don't throw in WASM setting

3c9f520

Align prove_tube

e591165

fix build

d4b8e47

fix error type in bberg test

ba96cdf

Merge branch 'master' into lde/msgpck_civc_proof

07cf0b7

use msgpack in write arb proof flow

ed5d1c6

test cleanup

3e10aac

reinstate phil example

81dc518

use throw or abort and remove ts changes

ca7e255

remove missed lines

5b10e01

add issue with note for immediate follow on

982b33c

codygunton approved these changes Mar 21, 2025

View reviewed changes

ledwards2225 enabled auto-merge (squash) March 21, 2025 19:33

ledwards2225 merged commit 1a01602 into master Mar 21, 2025
7 checks passed

ledwards2225 deleted the lde/msgpck_civc_proof branch March 21, 2025 20:02

AztecBot mentioned this pull request Mar 21, 2025

chore(master): release 0.82.1 #12943

Merged

ludamad reviewed Mar 22, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: use msgpack for ClientIvc::Proof in API#12911

feat: use msgpack for ClientIvc::Proof in API#12911
ledwards2225 merged 21 commits intomasterfrom
lde/msgpck_civc_proof

ledwards2225 commented Mar 20, 2025 •

edited

Loading

Uh oh!

ledwards2225 commented Mar 21, 2025

Uh oh!

Uh oh!

ludamad Mar 22, 2025

Uh oh!

ledwards2225 Mar 22, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ledwards2225 commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ledwards2225 commented Mar 21, 2025

Uh oh!

Uh oh!

ludamad Mar 22, 2025

Choose a reason for hiding this comment

Uh oh!

ledwards2225 Mar 22, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ledwards2225 commented Mar 20, 2025 •

edited

Loading