fix CONTAINSANY index use for lists of embedded documents

[gramian]

What does this PR do?

This change copies the cahnges made to CONTAINS for index use of lists of embedded documents to CONTAINSANY.

Motivation

Manual tests

Related issues

#2802

Checklist

• I have run the build using mvn clean package command
• My unit tests cover both failure and success scenarios

[gemini-code-assist]

Summary of Changes

Hello @gramian, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a limitation in the CONTAINSANY operator's ability to leverage indexes, particularly when dealing with lists of embedded documents and nested properties. By mirroring the index awareness logic previously implemented for the CONTAINS operator, this change ensures that CONTAINSANY can more effectively utilize BY-ITEM indexes, leading to improved query performance for relevant data structures.

Highlights

• Improved Index Awareness for CONTAINSANY: The CONTAINSANY operator now correctly identifies and utilizes indexes for queries involving lists of embedded documents and nested properties, aligning its behavior with the CONTAINS operator.
• Support for Nested Properties: The isIndexAware method in ContainsAnyCondition.java has been enhanced to parse and recognize nested property paths (e.g., 'tags.id') when determining index applicability.
• BY-ITEM Index Restriction: Index usage for CONTAINSANY is now explicitly restricted to BY-ITEM indexes, ensuring correct and efficient index application for list elements.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for f65ce89.

🟢 All jobs passed!

But CI Insights is watching 👀

[gemini-code-assist]

Code Review

This pull request ports the index usage logic for lists of embedded documents from CONTAINS to CONTAINSANY. The changes correctly extend index awareness to nested properties and add a necessary check for BY-ITEM indexes.

I've identified a couple of areas for improvement:

• A comment incorrectly refers to CONTAINS instead of CONTAINSANY.
• The regular expression for validating property paths has some issues: it doesn't support quoted identifiers (which is a correctness issue for properties with special names) and it incorrectly allows invalid paths with multiple dots. Since this logic is copied from ContainsCondition, the same issue might exist there and should ideally be fixed in both places.

Overall, the change is in the right direction to fix the reported issue.

[gemini-code-assist]

The regular expression used to validate the property path is both too restrictive and too permissive.

1. Too restrictive: It doesn't handle quoted identifiers (using backticks), which are necessary for property names with special characters like hyphens (e.g., `my-property`.name). This will cause index lookups to fail for such valid property paths.
2. Too permissive: It allows multiple consecutive dots (e.g., tags..id), which is not a valid property path syntax.

A more accurate validation might be needed here. Using a more robust regular expression or parsing the path to validate each segment would make this more reliable.

[lvca]

It looks good to me!

[gramian]

Can this be merged? The remark about the RegEx is valid, but needs to be done not only for CONTAINSANY but potentially all relevant filters.