fix: make values method behave like keys method

[gramian]

What does this PR do?

This change adds handling of collection arguments to the values method, copied from the keys method which already handles these argument types.

Motivation

Comparing outputs of keys and values methods.

Related issues

#2964

Checklist

• I have run the build using mvn clean package command
• My unit tests cover both failure and success scenarios

[gemini-code-assist]

Summary of Changes

Hello @gramian, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an inconsistency in the values SQL method by implementing support for collection arguments, mirroring the behavior of the keys method. This change ensures that values can now correctly process collections, providing a more robust and predictable API. The update includes modifications to the core method logic and corresponding unit tests to validate the new functionality.

Highlights

• Feature Parity: The values SQL method now supports collection arguments, aligning its behavior with the existing keys method to ensure consistent functionality.
• Collection Handling: The SQLMethodValues.java file was updated to correctly process Collection<?> inputs by recursively extracting values from their elements, enhancing its versatility.
• New Unit Tests: New unit tests, withCollection() and withNull(), were added in SQLMethodValuesTest.java to validate the proper handling of collection arguments and null inputs.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for a517425.

🟢 All jobs passed!

But CI Insights is watching 👀

[gemini-code-assist]

Code Review

This pull request aims to make the values method handle collection arguments, similar to the keys method. While the intent is good, the current implementation introduces a critical bug that can cause a NullPointerException when processing collections containing unsupported element types. Additionally, the logic for handling collections of Document objects is flawed due to a pre-existing issue, which will lead to incorrect results or a ClassCastException. I've provided a suggestion to make the collection handling safer, but further changes are needed for it to work correctly with Documents. The tests should also be expanded to cover these failure scenarios to prevent regressions.

[gemini-code-assist]

This implementation has two critical issues:

1. NullPointerException: If an element in the collection does not match any of the handled types, execute() returns null, causing an NPE when .stream() is called.
2. Incorrect result for Documents: For a Document, execute() returns a List<Collection<Object>>. The current code will throw a ClassCastException. The suggested fix below resolves the NPE and cast issue, but it will still produce a list of collections for Document inputs, not a flat list of values. This is due to an existing issue in how Document values are retrieved (List.of(document.toMap().values())). You should consider fixing that or adapting this logic to correctly flatten the results.

      final List<Object> result = collection.stream()
          .map(o -> execute(o, currentRecord, context, params))
          .filter(Collection.class::isInstance)
          .flatMap(c -> ((Collection<?>) c).stream()).toList();

[gemini-code-assist]

The new tests are a good start, but they don't cover all scenarios. The current implementation has issues with certain inputs that are not covered by these tests. Please consider adding more test cases to ensure robustness:

• A test with a collection of Document objects to verify correct flattening of values.
• A test with a collection containing mixed or unsupported types (e.g., List.of(Map.of("k", "v"), "some string")) to ensure NullPointerException is not thrown.
• A test with a collection of Result objects.