Update CLI Options

[gramian]

What does this PR do?

This change adds the Java CLI option to the console.sh and server.sh scripts. These prevent warnings when running either.

Motivation

Warnings during runtime. Also updating the obsolete --illegal-access=deny option in the console.

Related issues

Not an issue but a previous PR: #2698
Now, the option --sun-misc-unsafe-memory-access=allow is not added, as it was added in Java23.

Checklist

• I have run the build using mvn clean package command
• My unit tests cover both failure and success scenarios

[gemini-code-assist]

Summary of Changes

Hello @gramian, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the Java Virtual Machine (JVM) options within the console.sh and server.sh startup scripts. By updating these configurations, the goal is to eliminate runtime warnings and ensure better compatibility with newer Java versions, specifically by enabling native access and removing an obsolete flag that previously managed illegal access warnings.

Highlights

• Java CLI Option Update: Introduced the --enable-native-access=ALL-UNNAMED option to both console.sh and server.sh scripts.
• Obsolete Option Removal: Replaced the outdated --illegal-access=deny option in console.sh with the new native access flag.
• Warning Prevention: The changes are primarily aimed at preventing runtime warnings related to Java's internal API access and native code interactions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[mergify]

🧪 CI Insights

Here's what we observed from your CI run for 2a34efe.

🟢 All jobs passed!

But CI Insights is watching 👀

[gemini-code-assist]

Code Review

This pull request updates the Java CLI options in console.sh and server.sh to support newer Java versions and eliminate runtime warnings. The obsolete --illegal-access=deny option is correctly replaced in console.sh, and the --enable-native-access=ALL-UNNAMED option is consistently added to both scripts. The changes are correct and well-motivated. I've added one suggestion regarding code duplication between the two shell scripts to improve future maintainability.