Add arguments to server and console script to prevent warnings#2698
Add arguments to server and console script to prevent warnings#2698robfrank merged 3 commits intoArcadeData:mainfrom
Conversation
Summary of ChangesHello @gramian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses noisy startup logs by introducing specific JVM arguments to the console and server startup scripts. These changes aim to suppress warnings related to module access and native memory, providing a cleaner and less cluttered output during application initialization. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds several Java VM arguments to the console.sh and server.sh scripts to suppress warnings during startup. The added arguments (--enable-native-access=ALL-UNNAMED, --sun-misc-unsafe-memory-access=allow) and the removal of the deprecated --illegal-access=deny flag are appropriate for this purpose.
However, I've found a critical issue in console.sh where a line continuation character (\) was accidentally omitted. This will cause a syntax error and prevent the script from running correctly. Please see the detailed comment for the fix.
🧪 CI InsightsHere's what we observed from your CI run for f0b3383. 🟢 All jobs passed!But CI Insights is watching 👀 |
|
I don't see where a line continuation character is missing in |
(cherry picked from commit 428fe0d)
What does this PR do?
Arguments are added to the Java call in the console and serer scripts to prevent warnings on start up.
Motivation
Loud warnings in logs
Additional Notes
Tested with OpenJDK21 and OpenJDK25
Checklist
mvn clean packagecommand