Skip to content

Add arguments to server and console script to prevent warnings#2698

Merged
robfrank merged 3 commits intoArcadeData:mainfrom
gramian:main
Oct 24, 2025
Merged

Add arguments to server and console script to prevent warnings#2698
robfrank merged 3 commits intoArcadeData:mainfrom
gramian:main

Conversation

@gramian
Copy link
Collaborator

@gramian gramian commented Oct 23, 2025

What does this PR do?

Arguments are added to the Java call in the console and serer scripts to prevent warnings on start up.

Motivation

Loud warnings in logs

Additional Notes

Tested with OpenJDK21 and OpenJDK25

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @gramian, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses noisy startup logs by introducing specific JVM arguments to the console and server startup scripts. These changes aim to suppress warnings related to module access and native memory, providing a cleaner and less cluttered output during application initialization.

Highlights

  • JVM Argument Addition: Added --enable-native-access=ALL-UNNAMED to both console.sh and server.sh scripts to grant native access permissions.
  • Server Script Specific Argument: Included --sun-misc-unsafe-memory-access=allow in the server.sh script to permit unsafe memory access.
  • Argument Removal: Removed the --illegal-access=deny argument from the console.sh script.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds several Java VM arguments to the console.sh and server.sh scripts to suppress warnings during startup. The added arguments (--enable-native-access=ALL-UNNAMED, --sun-misc-unsafe-memory-access=allow) and the removal of the deprecated --illegal-access=deny flag are appropriate for this purpose.

However, I've found a critical issue in console.sh where a line continuation character (\) was accidentally omitted. This will cause a syntax error and prevent the script from running correctly. Please see the detailed comment for the fix.

@mergify
Copy link
Contributor

mergify bot commented Oct 23, 2025

🧪 CI Insights

Here's what we observed from your CI run for f0b3383.

🟢 All jobs passed!

But CI Insights is watching 👀

@gramian
Copy link
Collaborator Author

gramian commented Oct 24, 2025

I don't see where a line continuation character is missing in console.sh.

@robfrank robfrank merged commit 428fe0d into ArcadeData:main Oct 24, 2025
10 of 24 checks passed
robfrank added a commit that referenced this pull request Oct 24, 2025
robfrank pushed a commit that referenced this pull request Nov 10, 2025
robfrank added a commit that referenced this pull request Nov 10, 2025
@gramian gramian mentioned this pull request Nov 16, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants