Skip to content

Comments

Update Type Hinting from tuple to Tuple#910

Merged
ATheorell merged 1 commit intoAntonOsika:mainfrom
similato87:python-3.8-support
Dec 17, 2023
Merged

Update Type Hinting from tuple to Tuple#910
ATheorell merged 1 commit intoAntonOsika:mainfrom
similato87:python-3.8-support

Conversation

@similato87
Copy link
Collaborator

Changes

  • Replaced all instances of tuple[type, type] with Tuple[type, type].
  • Imported Tuple from the typing module wherever necessary.

@sweep-ai-deprecated
Copy link
Contributor

Apply Sweep Rules to your PR?

  • Apply: Ensure all new functions and classes have very clear, concise and up-to-date docstrings. Take gpt_engineer/ai.py as a good example.

@captivus
Copy link
Collaborator

Heya @similato87! First of all, thank you, indeed, for your eagerness to contribute!

The Board determined, recently, to bump the minimum version of Python supported to 3.10. Kindly let us revisit this topic prior to expending any more effort to expand support for versions below 3.10.

In the meanwhile, we welcome any additional contributions you'd be inclined to pickup from the Issues list!

@ATheorell ATheorell merged commit 4a49502 into AntonOsika:main Dec 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants