Skip to content

Comments

ci: use Python 3.10 in linting & testing#908

Merged
ErikBjare merged 4 commits intomainfrom
dev/ci-python-3.8
Dec 18, 2023
Merged

ci: use Python 3.10 in linting & testing#908
ErikBjare merged 4 commits intomainfrom
dev/ci-python-3.8

Conversation

@ErikBjare
Copy link
Collaborator

@ErikBjare ErikBjare commented Dec 16, 2023

As requested in #898 (comment)

Build will fail and linters will scream until the occurrences of type1 | type2 is replaced with Union[type1, type2].

Waiting for @similato87 to make the changes requested in #898 (comment)

@ErikBjare ErikBjare requested a review from ATheorell as a code owner December 16, 2023 11:45
@sweep-ai-deprecated
Copy link
Contributor

Apply Sweep Rules to your PR?

  • Apply: Ensure all new functions and classes have very clear, concise and up-to-date docstrings. Take gpt_engineer/ai.py as a good example.

@ATheorell
Copy link
Collaborator

Thanks @ErikBjare .
Do we need to make an explicit local rebase for checks to pass or is there an easier way?

@ErikBjare
Copy link
Collaborator Author

ErikBjare commented Dec 16, 2023

@ATheorell @similato87 There are more changes needed to make it supported on Python 3.8. See the failing CI log.

Mainly that things like tuple[int, int] needs to be Tuple[int, int] (default collections became types when subscripted in 3.9, they need their types imported from typing in 3.8).

@similato87
Copy link
Collaborator

similato87 commented Dec 17, 2023

@ATheorell @similato87 There are more changes needed to make it supported on Python 3.8. See the failing CI log.

Mainly that things like tuple[int, int] needs to be Tuple[int, int] (default collections became types when subscripted in 3.9, they need their types imported from typing in 3.8).

I've noticed the need for additional syntax adjustments to ensure Python 3.8 compatibility. I'm setting up a Python 3.8 environment to accurately test these changes, and then I'll proceed to update the type hinting throughout the codebase to make it fully compatible with Python 3.8.

@similato87
Copy link
Collaborator

Hi @ErikBjare , I finished refactored and created the new PR: #910

@ErikBjare
Copy link
Collaborator Author

There seems to be even more changes needed for 3.8 & 3.9 support.

Given the decision to bump the lowest supported version to 3.10, I will modify this PR to target 3.10 instead and get it merged.

@ErikBjare ErikBjare changed the title ci: use Python 3.8 in linting & testing (lowest supported version) ci: use Python 3.10 in linting & testing (lowest supported version) Dec 18, 2023
@ErikBjare ErikBjare changed the title ci: use Python 3.10 in linting & testing (lowest supported version) ci: use Python 3.10 in linting & testing Dec 18, 2023
@ErikBjare ErikBjare merged commit 02f99f1 into main Dec 18, 2023
@ErikBjare ErikBjare deleted the dev/ci-python-3.8 branch December 18, 2023 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants