Skip to content

Feature/string error codes#83

Merged
AndrejOrsula merged 6 commits intoAndrejOrsula:masterfrom
blooop:feature/string_error_codes
Feb 19, 2025
Merged

Feature/string error codes#83
AndrejOrsula merged 6 commits intoAndrejOrsula:masterfrom
blooop:feature/string_error_codes

Conversation

@blooop
Copy link
Contributor

@blooop blooop commented Feb 19, 2025

This improves the warning and error messages by printing the string value of the return code rather than the number. It uses a generic method for working out the appropriate string to print so that its easier to apply to any message type. That is probalby not optimal for performance but is simpler to integrate and is likely insignificant compared to time for other operations.

I've been using it for a week with no issues.

@AndrejOrsula
Copy link
Owner

This is very helpful. Thanks a lot, @blooop!

@blooop blooop requested a review from AndrejOrsula February 19, 2025 10:57
Copy link
Owner

@AndrejOrsula AndrejOrsula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, looks good!

@AndrejOrsula AndrejOrsula merged commit b8dde85 into AndrejOrsula:master Feb 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants