Skip to content

Refac: use dataSources instead of AltinnWindow#1214

Merged
olemartinorg merged 2 commits intomainfrom
refactor/simpleFunctionsExpressions
May 31, 2023
Merged

Refac: use dataSources instead of AltinnWindow#1214
olemartinorg merged 2 commits intomainfrom
refactor/simpleFunctionsExpressions

Conversation

@framitdavid
Copy link
Contributor

@framitdavid framitdavid commented May 30, 2023 •
edited
Loading

Description

Small refactoring to improve the code by using dataSources instead of AltinnWindow.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Changes/additions to component properties
    • Changes are reflected in both src/layout/layout.d.ts and layout.schema.v1.json, and these are all backwards-compatible
    • No changes made
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@framitdavid framitdavid added the kind/bug Something isn't working label May 30, 2023
@framitdavid framitdavid marked this pull request as ready for review May 30, 2023 13:32
@framitdavid framitdavid mentioned this pull request May 30, 2023
Merged
21 tasks
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

79.2% 79.2% Coverage
0.0% 0.0% Duplication

bjosttveit
bjosttveit approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@bjosttveit bjosttveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@framitdavid
Copy link
Contributor Author

framitdavid commented May 30, 2023

Docs for the new expression functions is ready to review here: Altinn/altinn-studio-docs#946

@olemartinorg olemartinorg merged commit ff59149 into main May 31, 2023
@olemartinorg olemartinorg deleted the refactor/simpleFunctionsExpressions branch May 31, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olemartinorg olemartinorg olemartinorg approved these changes

@bjosttveit bjosttveit bjosttveit approved these changes

Assignees

@framitdavid framitdavid

Labels

kind/bug Something isn't working

Projects

Team Apps
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Expressions: New simple functions

3 participants

@framitdavid @olemartinorg @bjosttveit