New functions to expressions

[framitdavid]

Description

Created new functions to be available for expressions, please see the issue for more details.

Working on documentation while this PR is in review.

Related Issue(s)

• closes Expressions: New simple functions #1176

Verification/QA

• Manual functionality testing
  • I have tested these changes manually
  • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
  • No testing done/necessary
• Automated tests
  • Unit test(s) have been added/updated
  • Cypress E2E test(s) have been added/updated
  • No automatic tests are needed here (no functional changes/additions)
  • I want someone to help me make some tests
• UU/WCAG (follow these guidelines until we have our own)
  • I have tested with a screen reader/keyboard navigation/automated wcag validator
  • No testing done/necessary (no DOM/visual changes)
  • I want someone to help me perform accessibility testing
• User documentation @ altinn-studio-docs
  • Has been added/updated
  • No functionality has been changed/added, so no documentation is needed
  • I will do that later/have created an issue
• Changes/additions to component properties
  • Changes are reflected in both src/layout/layout.d.ts and layout.schema.v1.json, and these are all backwards-compatible
  • No changes made
• Support in Altinn Studio
  • Issue(s) created for support in Studio
  • This change/feature does not require any changes to Altinn Studio
• Sprint board
  • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
  • I don't have permissions to do that, please help me out
• Labels
  • I have added a kind/* label to this PR for proper release notes grouping
  • I don't have permissions to add labels, please help me out

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

68.8% Coverage
0.0% Duplication

[bjosttveit]

Very nice! And great test coverage! Just one question, will expressions using state.textResources or selectedAppLanguage reevaluate if the language changes?

[framitdavid]

Very nice! And great test coverage! Just one question, will expressions using state.textResources or selectedAppLanguage reevaluate if the language changes?

@bjosttveit great question!👍 I was testing this by console.log "running language function" inside the language expression and it logs on every language change I did within the app, meaning it re-runs every time I change the language within the app.

[olemartinorg]

Ohh, I missed the review window on this one! 😬 I see you used the window object directly to get the current state instead of properly adding the state we depend on to dataSources. That's an immediate problem I think we should get sorted, but I'll do a more thorough review later.

[bjosttveit]

Ohh, I missed the review window on this one! 😬 I see you used the window object directly to get the current state instead of properly adding the state we depend on to dataSources. That's an immediate problem I think we should get sorted, but I'll do a more thorough review later.

Sorry I should probably have known that 😬

[framitdavid]

Ohh, I missed the review window on this one! 😬 I see you used the window object directly to get the current state instead of properly adding the state we depend on to dataSources. That's an immediate problem I think we should get sorted, but I'll do a more thorough review later.

Sorry I should probably have known that 😬

No worries, then we both learned something @bjosttveit. 😄 Thanks to @olemartinorg for catching this quite fast after the merge. I have a PR that should fix this problem. Ready for review: #1214

[framitdavid]

Docs PR is ready for review here. Altinn/altinn-studio-docs#946 :)