refactor: extract acro_artifacts folder name to ARTIFACTS_DIR constant#376
Open
Faadabu wants to merge 1 commit intoAI-SDC:mainfrom
Open
refactor: extract acro_artifacts folder name to ARTIFACTS_DIR constant#376Faadabu wants to merge 1 commit intoAI-SDC:mainfrom
Faadabu wants to merge 1 commit intoAI-SDC:mainfrom
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces all hardcoded
"acro_artifacts"strings with a globalARTIFACTS_DIRconstant, improving code maintainability.Changes
acro/constants.py(new): DefinesARTIFACTS_DIR = "acro_artifacts"acro/acro_tables.py: Replaced 15 occurrences acrosssurv_func,hist,pieacro/record.py: Replaced 2 occurrences infinalisetest/test_initial.py: Replaced 7 occurrences across plot/histogram/pie testsWhy
constants.pyinstead of__init__.py?A previous attempt (#361) placed the constant in
__init__.py, which caused circular imports. A standaloneconstants.pywith no internal package imports avoids this.Testing
pytest test/test_initial.py)Fixes #358