refactor: extract acro_artifacts folder name to global constant#361
Closed
Simon99 wants to merge 3 commits intoAI-SDC:mainfrom
Closed
refactor: extract acro_artifacts folder name to global constant#361Simon99 wants to merge 3 commits intoAI-SDC:mainfrom
Simon99 wants to merge 3 commits intoAI-SDC:mainfrom
Conversation
Replace all hardcoded 'acro_artifacts' strings with ARTIFACTS_DIR constant defined in acro/__init__.py. This improves maintainability and makes it easier to change the artifacts directory name in the future. Changes: - Added ARTIFACTS_DIR constant in acro/__init__.py - Updated acro/acro_tables.py to import and use ARTIFACTS_DIR - Updated acro/record.py to import and use ARTIFACTS_DIR - Updated test/test_initial.py to import and use ARTIFACTS_DIR - Updated log messages and comments to use the constant Fixes AI-SDC#358
for more information, see https://pre-commit.ci
Signed-off-by: Richard Preen <rpreen@gmail.com>
rpreen
requested changes
Mar 2, 2026
Collaborator
rpreen
left a comment
rpreen
left a comment
There was a problem hiding this comment.
Have you run the tests? This fails due to circular imports.
Collaborator
|
closing this as stale and broken. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces all hardcoded
acro_artifactsstrings with a globalARTIFACTS_DIRconstant, improving code maintainability.Changes
ARTIFACTS_DIR = "acro_artifacts"constant inacro/__init__.pyacro/acro_tables.py- replaced 10 occurrencesacro/record.py- replaced 3 occurrencestest/test_initial.py- replaced 3 occurrencesBenefits
Fixes
Fixes #358