Rewrite katello-certs-check to Ruby#978
Draft
ekohl wants to merge 2 commits intotheforeman:developfrom
Draft
Conversation
This makes it easier to maintain because the Ruby API is easier to handle than "parsing" the OpenSSL command line output.
ekohl
commented
Sep 17, 2024
|
|
||
| # TODO | ||
| check('Verifying root is included in bundle has CA:TRUE') do | ||
| # TODO: oid for basicConstraints? |
Member
Author
There was a problem hiding this comment.
I get the impression you can rely on the name, but I wonder if that's always true.
Member
Author
There was a problem hiding this comment.
Ideally this would overwrite the previous implementation and a drop in replacement, but now it's useful to have them side by side to compare.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to maintain because the Ruby API is easier to handle than "parsing" the OpenSSL command line output.
As you can see, still very much a work in progress but I'm opening this up for early feedback on the concept.