Make katello-certs-check mostly shellcheck clean#864
Open
ekohl wants to merge 1 commit intotheforeman:developfrom
Open
Make katello-certs-check mostly shellcheck clean#864ekohl wants to merge 1 commit intotheforeman:developfrom
ekohl wants to merge 1 commit intotheforeman:developfrom
Conversation
ekohl
commented
Jul 4, 2023
Member
Author
ekohl
left a comment
ekohl
left a comment
There was a problem hiding this comment.
It may be a good idea to apply shellcheck in CI somehow.
Comment on lines
+217
to
218
| DNS_LIST=$(openssl x509 -noout -text -in "$CERT_FILE" | grep DNS:) | ||
| if [[ $? == "0" ]]; then |
Member
Author
There was a problem hiding this comment.
This still yields and error but I'm not sure how to rewrite this so it doesn't.
| check-shortname | ||
|
|
||
| if [[ $EXIT_CODE == "0" ]] && ([[ $TARGET == ${SERVER_TARGET} ]] || [[ -z "$TARGET" ]]) ; then | ||
| if [[ $EXIT_CODE == "0" ]] && ([[ $TARGET == "${SERVER_TARGET}" ]] || [[ -z "$TARGET" ]]) ; then |
Member
Author
There was a problem hiding this comment.
Same here: it complains about the subshell.
Member
I added shellcheck i forklift recently, have a look :) |
Member
Author
|
At this point I think #978 might be a better direction. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.