Skip to content

1254 fix comscore notifyplay when surface is attached but player not playing #1256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StaehliJ wants to merge 3 commits into
base: main
Choose a base branch
from
Open

1254 fix comscore notifyplay when surface is attached but player not playing #1256

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
73ca683
Don't send notifyPlay when surface reconnecting in pause
StaehliJ Mar 2, 2026
a2a7791
Improve code
StaehliJ Mar 2, 2026
58193f5
Don't call clear it is handled by GC
StaehliJ Mar 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions ...iness/src/main/java/ch/srgssr/pillarbox/core/business/tracker/comscore/ComScoreTracker.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import ch.srgssr.pillarbox.player.tracker.MediaItemTracker
import ch.srgssr.pillarbox.player.utils.DebugLogger
import com.comscore.streaming.ContentMetadata
import com.comscore.streaming.StreamingAnalytics
import java.lang.ref.WeakReference

/**
* A [MediaItemTracker] implementation for ComScore analytics.
Expand All @@ -43,13 +44,15 @@ class ComScoreTracker internal constructor(
*/
private var isSurfaceConnected: Boolean = false
private var isBuffering: Boolean = false
private lateinit var player: WeakReference<ExoPlayer>

init {
streamingAnalytics.setMediaPlayerName(MEDIA_PLAYER_NAME)
streamingAnalytics.setMediaPlayerVersion(BuildConfig.VERSION_NAME)
}

override fun start(player: ExoPlayer, data: Data) {
this.player = WeakReference<ExoPlayer>(player)
isSurfaceConnected = player.surfaceSize != Size.ZERO
streamingAnalytics.createPlaybackSession()
setMetadata(data)
Expand All @@ -74,7 +77,7 @@ class ComScoreTracker internal constructor(
private fun handleStart(player: ExoPlayer) {
streamingAnalytics.notifyChangePlaybackRate(player.getPlaybackSpeed())
when {
player.isPlaying -> {
player.isPlaying && !player.currentTimeline.isEmpty -> {
player.currentTimeline.getWindow(player.currentMediaItemIndex, window)
notifyPlay(player.currentPosition, window)
}
Expand All @@ -95,6 +98,13 @@ class ComScoreTracker internal constructor(
streamingAnalytics.notifyPlay()
}

private fun notifyPlay(eventTime: AnalyticsListener.EventTime) {
if (!eventTime.timeline.isEmpty) {
eventTime.timeline.getWindow(eventTime.windowIndex, window)
notifyPlay(eventTime.eventPlaybackPositionMs, window)
}
}

private fun notifyEnd() {
DebugLogger.debug(TAG, "notifyEnd")
streamingAnalytics.notifyEnd()
Expand Down Expand Up @@ -192,10 +202,8 @@ class ComScoreTracker internal constructor(
}

override fun onIsPlayingChanged(eventTime: AnalyticsListener.EventTime, isPlaying: Boolean) {
val position = eventTime.eventPlaybackPositionMs
eventTime.timeline.getWindow(eventTime.windowIndex, window)
if (isPlaying) {
notifyPlay(position, window)
notifyPlay(eventTime)
} else {
if (!isBuffering) {
notifyPause()
Expand All @@ -206,12 +214,10 @@ class ComScoreTracker internal constructor(
override fun onSurfaceSizeChanged(eventTime: AnalyticsListener.EventTime, width: Int, height: Int) {
val isCurrentSurfaceConnected = Size(width, height) != Size.ZERO
if (isCurrentSurfaceConnected != isSurfaceConnected) {
Log.d(TAG, "Surface connected change $isSurfaceConnected -> $isCurrentSurfaceConnected")
Log.d(TAG, "Surface connected change $isSurfaceConnected -> $isCurrentSurfaceConnected ${player.get()?.isPlaying}")
isSurfaceConnected = isCurrentSurfaceConnected
if (isCurrentSurfaceConnected) {
val position = eventTime.eventPlaybackPositionMs
eventTime.timeline.getWindow(eventTime.windowIndex, window)
notifyPlay(position, window)
if (isCurrentSurfaceConnected && player.get()?.isPlaying == true) {
notifyPlay(eventTime)
} else {
notifyPause()
}
Expand Down