Skip to content

1254 fix comscore notifyplay when surface is attached but player not playing#1256

Open
StaehliJ wants to merge 3 commits intomainfrom
1254-fix-comscore-notifyplay-when-surface-is-attached-but-player-not-playing
Open

1254 fix comscore notifyplay when surface is attached but player not playing#1256
StaehliJ wants to merge 3 commits intomainfrom
1254-fix-comscore-notifyplay-when-surface-is-attached-but-player-not-playing

Conversation

@StaehliJ
Copy link
Contributor

@StaehliJ StaehliJ commented Mar 2, 2026

Description

Fix ComScoreTracker sending notfiyPlay even if the player is paused when surface connect again.

Changes made

  • Avoid sending notifyPlay when surface connecting in pause

Checklist

  • APIs have been properly documented (if relevant).
  • The documentation has been updated (if relevant).
  • New unit tests have been written (if relevant).
  • The demo has been updated (if relevant).

@StaehliJ StaehliJ requested a review from njabal March 2, 2026 08:53
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Code Coverage

Overall Project 44.53% -0.14% 🟢
Files changed 39.13% 🟢

Module Coverage
:pillarbox-core-business 78.48% -0.85% 🟢
Files
Module File Coverage
:pillarbox-core-business ComScoreTracker.kt 82.21% -12.61% 🟢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋 Backlog

Development

Successfully merging this pull request may close these issues.

FIX Comscore notifyPlay when surface is attached but player not playing

1 participant