bugfix: helper: Check view is rendered before displaying errors.#761
Merged
neiljp merged 1 commit intozulip:masterfrom Aug 2, 2020
Merged
bugfix: helper: Check view is rendered before displaying errors.#761neiljp merged 1 commit intozulip:masterfrom
neiljp merged 1 commit intozulip:masterfrom
Conversation
kaustubh-nair
approved these changes
Aug 2, 2020
Collaborator
|
@sumanthvrao Thanks for this - merging this promptly so that it allows people to use the git version for now! in case they run into this race. As we discussed on the stream, these issues should be resolved post-#667. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A quick oneliner which hopefully fixes some errors which are caused trying to display an error in the footer, before the view is loaded.