Conversation
rdoria1
force-pushed
the
update-polkadot-1.15.0
branch
from
baeecee to
6967830
Compare
95DDB
reviewed
Oct 28, 2024
| sc_consensus_grandpa::grandpa_peers_set_config(grandpa_protocol_name.clone()); | ||
| sc_consensus_grandpa::grandpa_peers_set_config::<_, Network>( | ||
| grandpa_protocol_name.clone(), | ||
| NotificationMetrics::new(None), |
Collaborator
There was a problem hiding this comment.
Shouldn't we attach our Prometheus metrics here ?
Contributor
Author
There was a problem hiding this comment.
Didn't know we had Prometheus metrics, in that case yes, I think they should go here. I'll dig a bit more.
Contributor
There was a problem hiding this comment.
Sorry I just noticed this; indeed, we should attach prometheus metrics here. I can change this in #168.
95DDB
reviewed
Oct 28, 2024
95DDB
reviewed
Oct 28, 2024
95DDB
reviewed
Oct 28, 2024
node/src/chain_spec.rs
Outdated
| Ok(ChainSpec::builder( | ||
| WASM_BINARY.ok_or_else(|| "Development wasm not available".to_string())?, | ||
| None, | ||
| Default::default(), |
Contributor
Author
There was a problem hiding this comment.
my bad, this was something I forgot to undo due to some change that was not needed in the end.
Bottom line: No need to do this, I'll undo it.
rdoria1
force-pushed
the
update-polkadot-1.15.0
branch
from
74d0ba9 to
845cd5c
Compare
Collaborator
|
Closing in favor of #168 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pallet treasury
remove ApproveOrigin -> Found this comment on this type before it was effectively removed https://github.com/paritytech/polkadot-sdk/pull/4831/files
// The creation of proposals via the treasury pallet is deprecated and should not be utilized.
// Instead, public or fellowship referenda should be used to propose and command the treasury
// spend or spend_local dispatchables. The parameters below have been configured accordingly to
// discourage its use.
Remove OnSlash-> This was added to the bounty pallets instead (PR comment in paritytech/polkadot-sdk#4831)
Remove ProposalBond ProposalBondMinimum and ProposalBondMaximum -> paritytech/polkadot-sdk@3d26a92 I feel this is because they all related to proposal and based on the first point. proposals are not done via the treasury pallet anymore which is why these types are useless now
Pallet bounties
Added OnSlash as specified before, coming from treasury
Pallet staking
Replace OffendingValidatorsThreshold with DisablingStrategy paritytech/polkadot-sdk#2226
node
remove deprecated RuntimeGenesisConfig : paritytech/polkadot-sdk#4410
TODO Re run benchmark for pallet_balances