2D API wrapper #28
Merged
2D API wrapper #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eskaur
reviewed
Nov 18, 2019
Member
eskaur
left a comment
eskaur
left a comment
There was a problem hiding this comment.
Looks very good to me. Great test-coverage too.
I just have a few minor comments/questions.
trym-b
force-pushed
the
python-2d-api
branch
from
9755225 to
d6c0e51
Compare
Contributor
Author
|
Ready for next round |
nedrebo
reviewed
Nov 19, 2019
nedrebo
reviewed
Nov 19, 2019
Contributor
Author
|
Ready for next round @nedrebo |
nedrebo
reviewed
Nov 21, 2019
Contributor
nedrebo
left a comment
nedrebo
left a comment
There was a problem hiding this comment.
This looks good, only minor comments.
trym-b
force-pushed
the
python-2d-api
branch
2 times, most recently
from
2f28ac1 to
62a10a1
Compare
nedrebo
reviewed
Nov 25, 2019
src/ReleasableImage.cpp
Outdated
|
|
||
| return py::buffer_info{ | ||
| const_cast<Zivid::RGBA8 *>( | ||
| data), // TODO: Const casting this until https://github.com/pybind/pybind11/issues/1993 has been solved |
Contributor
There was a problem hiding this comment.
This is now merged. The fix is now to simply remove the const cast once pybind11 is updated.
trym-b
force-pushed
the
python-2d-api
branch
3 times, most recently
from
5405790 to
9339676
Compare
apartridge
reviewed
Nov 25, 2019
Contributor
Author
|
Any more comments @apartridge, @nedrebo or @eskaur ? |
Enables 2D API in this wrapper, so that you can easily capture 2D images using a camera. 2D sample capture and tests has been included.
trym-b
force-pushed
the
python-2d-api
branch
from
9339676 to
14312c5
Compare
eskaur
approved these changes
Nov 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables 2D API in this wrapper, so that you can easily capture 2D images
using a camera. 2D sample capture and tests has been included.