integrate #3166 from Faiss baseline#563
Conversation
|
@alexanderguzhva 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #563 +/- ##
=========================================
+ Coverage 0 70.04% +70.04%
=========================================
Files 0 67 +67
Lines 0 4597 +4597
=========================================
+ Hits 0 3220 +3220
- Misses 0 1377 +1377 |
|
/hold |
Signed-off-by: Alexandr Guzhva <[email protected]>
d09effb to
4e07caf
Compare
|
added even more removed instructions |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderguzhva, PwzXxm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind enhancement |
issue #462
Faiss baseline PRs:
Basically, this PR implements ARM NEON code for ScalarQuantizer.
All knowhere tests pass on my ARM machine.