Skip to content

[bug] fix IVFPQFastScan::RangeSearch() on ARM#1116

Merged
sre-ci-robot merged 1 commit intozilliztech:mainfrom
alexanderguzhva:fix_ivfpqfastscan
Mar 20, 2025
Merged

[bug] fix IVFPQFastScan::RangeSearch() on ARM#1116
sre-ci-robot merged 1 commit intozilliztech:mainfrom
alexanderguzhva:fix_ivfpqfastscan

Conversation

@alexanderguzhva
Copy link
Collaborator

@alexanderguzhva alexanderguzhva commented Mar 18, 2025

A non-trivial bug in the FAISS code. Check facebookresearch/faiss#4247

the problem happens if radius - normalizers[2 * q + 1] is negative. Thus, it is possible to provide reasonable parameters to IVFPQFastScan::RangeSearch() and get an empty result.

issue: #1100

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot requested review from hhy3 and liliu-z March 18, 2025 22:04
@alexanderguzhva alexanderguzhva changed the title fix IVFPQFastScan::RangeSearch() on ARM [bug] fix IVFPQFastScan::RangeSearch() on ARM Mar 18, 2025
@mergify
Copy link

mergify bot commented Mar 18, 2025

@alexanderguzhva 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@alexanderguzhva
Copy link
Collaborator Author

alexanderguzhva commented Mar 18, 2025

/kind bug

@alexanderguzhva
Copy link
Collaborator Author

issue: #1100

@alexanderguzhva
Copy link
Collaborator Author

/kind improvement

Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot merged commit 8ba5491 into zilliztech:main Mar 20, 2025
11 of 12 checks passed
Copy link
Collaborator

@liliu-z liliu-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants