Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alexanderguzhva The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@alexanderguzhva 🔍 Important: PR Classification Needed! For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:
For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”. Thanks for your efforts and contribution to the community!. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (50.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1115 +/- ##
============================
============================
🚀 New features to boost your workflow:
|
81f930a to
d29e771
Compare
d29e771 to
33de8eb
Compare
| faiss::IndexIVFScalarQuantizer) | ||
| KNOWHERE_MOCK_REGISTER_DENSE_FLOAT_ALL_GLOBAL(IVF_SQ_CC, IvfIndexNode, knowhere::feature::NONE, | ||
| faiss::IndexIVFScalarQuantizerCC) | ||
| KNOWHERE_MOCK_REGISTER_DENSE_FLOAT_ALL_GLOBAL(IVFRABITQ, IvfIndexNode, knowhere::feature::MMAP, IndexIVFRaBitQWrapper) |
There was a problem hiding this comment.
Note that iterator is not supported
There was a problem hiding this comment.
Aren't iterator facilities provided automatically with all the underlying code? If not, then what's missing?
|
/lgtm overall |
let me address the comments first, they make sense. |
33de8eb to
59fb069
Compare
59fb069 to
db6e471
Compare
|
added iterators |
Signed-off-by: Alexandr Guzhva <[email protected]>
Signed-off-by: Alexandr Guzhva <[email protected]>
Signed-off-by: Alexandr Guzhva <[email protected]>
Signed-off-by: Alexandr Guzhva <[email protected]>
Signed-off-by: Alexandr Guzhva <[email protected]>
47145e7 to
91bff20
Compare
|
issue: #1137 |
|
/kind improvement |
|
/lgtm |
the corresponsing faiss PR is facebookresearch/faiss#4235
Also, synchronizes with facebookresearch/faiss#4250
This PR also synchronizes
faiss/impl/ResultHandler.handfaiss/utils/distances.cppwith the baseline implementation. Check if any side-effects / bugs appearissue: #1137