Skip to content

RaBitQ implementation#1115

Merged
sre-ci-robot merged 5 commits intozilliztech:mainfrom
alexanderguzhva:ivfrabitq_protow
Apr 10, 2025
Merged

RaBitQ implementation#1115
sre-ci-robot merged 5 commits intozilliztech:mainfrom
alexanderguzhva:ivfrabitq_protow

Conversation

@alexanderguzhva
Copy link
Collaborator

@alexanderguzhva alexanderguzhva commented Mar 11, 2025

the corresponsing faiss PR is facebookresearch/faiss#4235
Also, synchronizes with facebookresearch/faiss#4250

This PR also synchronizes faiss/impl/ResultHandler.h and faiss/utils/distances.cpp with the baseline implementation. Check if any side-effects / bugs appear

issue: #1137

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexanderguzhva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify
Copy link

mergify bot commented Mar 11, 2025

@alexanderguzhva 🔍 Important: PR Classification Needed!

For efficient project management and a seamless review process, it's essential to classify your PR correctly. Here's how:

  1. If you're fixing a bug, label it as kind/bug.
  2. For small tweaks (less than 20 lines without altering any functionality), please use kind/improvement.
  3. Significant changes that don't modify existing functionalities should be tagged as kind/enhancement.
  4. Adjusting APIs or changing functionality? Go with kind/feature.

For any PR outside the kind/improvement category, ensure you link to the associated issue using the format: “issue: #”.

Thanks for your efforts and contribution to the community!.

@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (3c46f4c) to head (91bff20).
Report is 345 commits behind head on main.

❌ Your project status has failed because the head coverage (0.00%) is below the target coverage (50.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@     Coverage Diff      @@
##   main   #1115   +/-   ##
============================
============================
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

faiss::IndexIVFScalarQuantizer)
KNOWHERE_MOCK_REGISTER_DENSE_FLOAT_ALL_GLOBAL(IVF_SQ_CC, IvfIndexNode, knowhere::feature::NONE,
faiss::IndexIVFScalarQuantizerCC)
KNOWHERE_MOCK_REGISTER_DENSE_FLOAT_ALL_GLOBAL(IVFRABITQ, IvfIndexNode, knowhere::feature::MMAP, IndexIVFRaBitQWrapper)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that iterator is not supported

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't iterator facilities provided automatically with all the underlying code? If not, then what's missing?

@foxspy
Copy link
Collaborator

foxspy commented Mar 31, 2025

/lgtm overall
remove WIP to merge

@alexanderguzhva
Copy link
Collaborator Author

alexanderguzhva commented Mar 31, 2025

/lgtm overall remove WIP to merge

let me address the comments first, they make sense.
Plus, I'd like to include some standalone UTs

@alexanderguzhva
Copy link
Collaborator Author

added iterators

@mergify mergify bot removed the ci-passed label Apr 1, 2025
@alexanderguzhva alexanderguzhva changed the title [WIP] RaBitQ implementation RaBitQ implementation Apr 1, 2025
Signed-off-by: Alexandr Guzhva <[email protected]>
@alexanderguzhva
Copy link
Collaborator Author

issue: #1137

@alexanderguzhva
Copy link
Collaborator Author

/kind improvement

@foxspy
Copy link
Collaborator

foxspy commented Apr 7, 2025

/lgtm

@mergify mergify bot added the ci-passed label Apr 10, 2025
@sre-ci-robot sre-ci-robot merged commit c87c16e into zilliztech:main Apr 10, 2025
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants