Fix light effect not being turned off sometimes#733
Draft
TheJulianJES wants to merge 2 commits intozigpy:devfrom
Draft
Fix light effect not being turned off sometimes#733TheJulianJES wants to merge 2 commits intozigpy:devfrom
TheJulianJES wants to merge 2 commits intozigpy:devfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #733 +/- ##
==========================================
+ Coverage 97.63% 97.66% +0.03%
==========================================
Files 62 62
Lines 10814 10825 +11
==========================================
+ Hits 10558 10572 +14
+ Misses 256 253 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheJulianJES
added a commit
to TheJulianJES/zha
that referenced
this pull request
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DRAFT. Should be cleaned up further.
Proposed change
This fixes an issue where sending a light turn on command with a color temperature does not cause some lights to switch into color temperature mode if the "color loop" effect is currently active.
Previously, we only turned off the effect after sending color (temp) commands. Now, we also do it before, though only if we're certain that an effect is active, to not send unnecessary packets.
Notes
Lights continue to be one of the most complicated things to do 100% right. This is the one known issue that happens in some cases.
In general, the light class will be cleaned up soon a bit. I want to increase test coverage for all edge cases before, though.
This PR may be adjusted and merged only after that's done. We'll see.
Additional information