Fix prevent_default_entity_creation ignoring cluster_type#716
Draft
TheJulianJES wants to merge 2 commits intozigpy:devfrom
Draft
Fix prevent_default_entity_creation ignoring cluster_type#716TheJulianJES wants to merge 2 commits intozigpy:devfrom
prevent_default_entity_creation ignoring cluster_type#716TheJulianJES wants to merge 2 commits intozigpy:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
This fixes an issue where
prevent_default_entity_creationignored acluster_typewhen provided.Note: The zigpy metadata defaults to
cluster_type=.SERVR, so this changes the behavior wherecluster_typeis currently omitted. We'll need to re-evaluate all quirks usage of this to see if a client and/or server entity should be hidden instead.Additional information
Fixes:
prevent_default_entity_creationcluster_typedoesn't work forOnOffopening entity in ZHA zha-device-handlers#4284