This repository was archived by the owner on Nov 25, 2025. It is now read-only.
fix incorrect URL to .minisig file
#479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I guess I only tested my cache changes without your URL changes... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have unfortunately managed to sneak in another regression while trying to fix the previous one. The
artifactMinisignUrlwill always be incorrect because it appends.minisigafter appending?source=ziglang-vscode-zigwhich would result in the following URL:so it downloads the tarball/zip again instead of the minisig and then silently fails during verification. This will then repeat for every mirror until utimately failing with ziglang.org. During testing I always aborted the installation early before reaching minisign verification so I didn't notice my mistake. Sorry about that.