VRC7 audio: support for custom patch sets#2
Open
nununoisy wants to merge 1 commit intozeta0134:masterfrom
Open
VRC7 audio: support for custom patch sets#2nununoisy wants to merge 1 commit intozeta0134:masterfrom
nununoisy wants to merge 1 commit intozeta0134:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a method
vrc7_set_patches()to theMappertrait that allows the replacement of the built in patchset. There are impls of the method for bothVrc7andNsfMapper. This allows for:VRC7field in NSFe/NSF2 modulesThis was already implemented in NSFPresenter's fork of RusticNES. Here's an example invocation if you want to get an idea of what the API looks like.