fix: font family not importing from theme.json (closes #1376)#1735
Open
venkey-dev wants to merge 6 commits intozeshuaro:mainfrom
Open
fix: font family not importing from theme.json (closes #1376)#1735venkey-dev wants to merge 6 commits intozeshuaro:mainfrom
venkey-dev wants to merge 6 commits intozeshuaro:mainfrom
Conversation
venkey-dev
changed the title
Ensure FontPicker shows default font when initial is null/empty, add comprehensive widget tests, and provide FontRepository in all relevant test setups.
…dary This commit updates the font selection logic to prioritize `fontFamilyFallback` over the direct `fontFamily` property of a `TextStyle`. Previously, only the `fontFamilyFallback` was considered. Now, the logic is updated to first check for a `fontFamilyFallback` and, if it's not present, to then use the `fontFamily` property. This ensures a more robust font resolution, especially for theme-level font definitions. Corresponding tests have been added to verify the new behavior.
… 1376-fix-font-family-import
Author
|
Hay @zeshuaro , I have Run the Same Workflows for this Branch in My local Repository thay also given Error I tried Once again they Got Fixed without any Changes can U also try rerun these workflows (only failed once)? GitHub Actions Workflow : https://github.com/venkat-clone/appainter/actions/runs/20594678830 |
… 1376-fix-font-family-import
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: font family not importing from theme.json (closes #1376)
Fixes #1376
Description
This PR fixes the bug where a custom font family selected in Text Theme (e.g., Montserrat, Roboto Mono, etc.) is lost when the theme is exported to
theme.jsonand then re-imported. After the fix, the chosen font family is correctly saved in the JSON file and restored on import.Changes
TextTheme.fontFamilyand related fallback fonts during theme exporttheme.jsonTesting
Tested on https://appainter.dev (web):
theme.jsontheme.jsonNo regressions observed in other theme sections.
Closes #1376