Safer regex replace, keeping options like "/Zc:twoPhase-" intact#3668
Merged
bluca merged 2 commits intozeromq:masterfrom Sep 4, 2019
Merged
Safer regex replace, keeping options like "/Zc:twoPhase-" intact#3668bluca merged 2 commits intozeromq:masterfrom
bluca merged 2 commits intozeromq:masterfrom
Conversation
Member
|
Could you please add a commit with a relicense statement? See https://github.com/zeromq/libzmq/blob/master/RELICENSE/README.md |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In our project, we include libzmq via the FetchContent mechanism and add it using add_subdirectory. In the already set CMAKE_CXX_FLAGS_DEBUG and CMAKE_CXX_FLAGS_RELWITHDEBINFO, we have multiple flags set, such as /Zc:twoPhase-. By applying the regex replace, this was converted to /Z7:twoPhase-, which caused the compilation to fail. The now proposed regex replace is a bit safer, as it does not touch flags containing a ":".