[DragonFlyBSD] fix for IPv4 mapping not supported - #3608
Merged
Conversation
solution: on DragonFly also define ZMQ_HAVE_FREEBSD
in addition to ZMQ_HAVe_DRAGONFLY
Signed-off-by: Christopher Hall <hsw@ms2.hinet.net>
…hen IPv6 is used solution: Handle as for OpenBSD by not attemption to set this option on the socket Signed-off-by: Christopher Hall <hsw@ms2.hinet.net>
hxw
referenced
this pull request
in DragonFlyBSD/DeltaPorts
Aug 6, 2019
- Handle v4-mapping as for OpenBSD. DragonFly BSD does not allow mapping global IPv4 addresses when IPv6 is used. Reported by: Christopher Hall (hxw) #208
Member
|
Thanks a lot for the fix! Please consider also adding a known user entry for DragonFly to https://github.com/zeromq/libzmq/blob/master/README.md Thanks! |
Member
|
@hxw could you please send another PR with a relicense statement? As explained in https://github.com/zeromq/libzmq/blob/master/.github/CONTRIBUTING.md and https://github.com/zeromq/libzmq/tree/master/RELICENSE |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On DragonFly the zmq::enable_ipv4_mapping in ip.cpp fais with a not supported error
So handle this case the same as for OpenBSD
Also update configure files to set the correct definitions for DragonFly OS
This includes all patches from the dports/net/libzmq/dragonfly patches directory