fix: timelock policy create proposal using erc4337 with no-op calldata#36
Merged
fix: timelock policy create proposal using erc4337 with no-op calldata#36
Conversation
leekt
force-pushed
the
fix/tob-kernel-1
branch
from
7777ec8 to
4e950ed
Compare
leekt
force-pushed
the
fix/tob-kernel-1
branch
from
c9e7ab1 to
baa9fa6
Compare
leekt
changed the title
leekt
changed the title
leekt
changed the title
fix: timelock policy to clear state when reinstalled
fix: TimelockPolicy to not accept erc1271
fix(TimelockPolicy): correct ERC-7579 no-op detection encoding
fix(TimelockPolicy): add upper bounds for delay and expirationPeriod
fix(TimelockPolicy): add grace period to prevent cancellation race condition
Fix/delete create proposal
fix(TimelockPolicy): use Guardian for cancellation, proper no-op decoding
…plugins into fix/tob-kernel-1
…or, ECDSASigner, WeightedECDSASigner
fix: add install-time input validation (TOB-KERNEL-5)
fix: add zero-owner/signer guard in validation functions (TOB-KERNEL-13)
chore: replace string literal requires/reverts with custom errors
docs: add security assumption NatSpec comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fixes tob-kernel-2 on #37 and tob-kernel-20 on #42