Conversation
…ve sleep(5 seconds)
tdbesson
approved these changes
Oct 16, 2025
gadfort
reviewed
Oct 16, 2025
Comment on lines
+7
to
+8
| "models": { | ||
| }, |
Contributor
There was a problem hiding this comment.
probably makes sense to have a test that includes the models to ensure this behavior is properly implemented at this time.
| endmodule | ||
| EOF | ||
|
|
||
| synth_fpga -partname z1000 |
Contributor
There was a problem hiding this comment.
test says z1010, but partname does not match
Comment on lines
+29
to
+30
| select -assert-count 9 */t:dffr | ||
| select -assert-count 11 */t:$lut |
Contributor
There was a problem hiding this comment.
might be good to add some log assertions to ensure the z1010 name is kept from the start of the flow though the end of flow
| endmodule | ||
| EOF | ||
|
|
||
| synth_fpga -config data/z1000/z1000_abspath.json -show_config |
Collaborator
|
@gigeresk Fred, BTW, please can you update the README part where the config file usage is explained and add the last features you just added with and example ? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Deprecate ff_models field- Add notion of "illegal final state cells" from config file to throw an error if intermediate techmap cells are still present at the end of synth, and move current MAE techmap fail error to end of synth