drivers: i2c: add i2c target support for ambiq soc#96059
drivers: i2c: add i2c target support for ambiq soc#96059AlessandroLuo wants to merge 3 commits intozephyrproject-rtos:mainfrom
Conversation
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
AlessandroLuo
force-pushed
the
ambiq-ios-i2c
branch
from
bcabae5 to
4dbc8d1
Compare
AlessandroLuo
force-pushed
the
ambiq-ios-i2c
branch
4 times, most recently
from
51430e9 to
fbebf82
Compare
|
zephyrbot
added
area: I2C
area: MFD
platform: Ambiq
zephyrbot
requested review from
JarmouniA,
RichardSWheatley,
aaronyegx,
aasinclair,
decsny,
kartben,
nashif,
nordic-auko,
seov-nordic,
tbursztyka and
teburd
There was a problem hiding this comment.
This seems to only implement the optional buf_read/buf_write callbacks from the ISR but these are likely the least used.
read_requested/read_processed and such are far more widely in use today.
Does this work with any of the in tree tests or samples? I'd guess it does not.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Comments suppressed due to low confidence (2)
drivers/spi/spi_ambiq_spid.c:1
- The error message should clarify that exactly one child must be enabled, not just that there are 'too many'. Consider: 'IOS must have exactly one enabled child (either SPI or I2C, not both)!'
/*
drivers/i2c/i2c_ambiq_ios.c:1
- The error message should clarify that exactly one child must be enabled, not just that there are 'too many'. Consider: 'IOS must have exactly one enabled child (either SPI or I2C, not both)!'
/*
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Adds bingding for ambiq ios which can used as spi device or i2c target, and creates ios i2c driver. Signed-off-by: Hao Luo <hluo@ambiq.com>
Adds byte mode for i2c_ambiq_ios. Signed-off-by: Hao Luo <hluo@ambiq.com>
Adds pm_device_get/put in i2c_ambiq_ios to support pm_device_runtime. Signed-off-by: Hao Luo <hluo@ambiq.com>
AlessandroLuo
force-pushed
the
ambiq-ios-i2c
branch
from
fbebf82 to
670b267
Compare
|
Hi @teburd, I have added support for the byte mode as well, and ran samples\drivers\i2c\target_eeprom and tests\drivers\i2c\i2c_target_api with ambiq platforms, both passed, please help to review again, thank you. |
|
Retriggering CI |
zephyrbot
added
the
area: Devicetree Binding
|
|
The CI failure is due to #85248 (comment) |
Adds bingding for ambiq ios which can used as spi device or i2c target, and creates ios i2c driver.