Skip to content

scripts: check_compliance: add DER certificates to allowed binaries#78797

Closed
josuah wants to merge 1 commit intozephyrproject-rtos:mainfrom
josuah:pr-scripts-ci-check-compliance-der
Closed

scripts: check_compliance: add DER certificates to allowed binaries#78797
josuah wants to merge 1 commit intozephyrproject-rtos:mainfrom
josuah:pr-scripts-ci-check-compliance-der

Conversation

@josuah
Copy link
Copy Markdown
Contributor

@josuah josuah commented Sep 21, 2024

There are already plenty of DER certificate files through the tree, this patch allows to commit sample certificates to samples such as network libraries.

I hope I interpreted @jukkar's comment well:

My bad for missing his former #72804 (comment)

Or maybe the goal is to keep the "forbidden binaries" and manually override the check...

There are already plenty of DER certificate files through the tree,
this patch allows to commit sample certificates to samples such as
network libraries.

Signed-off-by: Josuah Demangeon <me@josuah.net>
Copy link
Copy Markdown
Member

@fabiobaltieri fabiobaltieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @josuah, this was considered before and we ended up not doing it on the basis of these being only added on one offs when new samples are introduced (while images are being added all the time with board and documentation). I think we are better off with the extra scrutiny of having an admin bypass the check, which I think is what we should do with the PR you mentioned.

Just to check, you don't expect these to change ever, right?

Or maybe the goal is to keep the "forbidden binaries" and manually override the check...

Yes.

@jukkar
Copy link
Copy Markdown
Member

jukkar commented Sep 21, 2024

Duplicate of #70817

@jukkar jukkar marked this as a duplicate of #70817 Sep 21, 2024
@josuah
Copy link
Copy Markdown
Contributor Author

josuah commented Sep 21, 2024

@jukkar I need to checking the context of PRs a lot more. 😓

Just to check, you don't expect these to change ever, right?

Yes certificates will likely stay the same for the lifetime of the sample.

Thank you for helping me catching-up.
Sorry for the unnecessary noise.

@josuah josuah closed this Sep 21, 2024
@josuah josuah deleted the pr-scripts-ci-check-compliance-der branch September 21, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Coding Guidelines Coding guidelines and style area: Continuous Integration area: Samples Samples area: Scripts Scripts size: XS A PR changing only a single line of code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants