scripts: check_compliance: add DER certificates to allowed binaries#78797
scripts: check_compliance: add DER certificates to allowed binaries#78797josuah wants to merge 1 commit intozephyrproject-rtos:mainfrom
Conversation
There are already plenty of DER certificate files through the tree, this patch allows to commit sample certificates to samples such as network libraries. Signed-off-by: Josuah Demangeon <me@josuah.net>
There was a problem hiding this comment.
Hey @josuah, this was considered before and we ended up not doing it on the basis of these being only added on one offs when new samples are introduced (while images are being added all the time with board and documentation). I think we are better off with the extra scrutiny of having an admin bypass the check, which I think is what we should do with the PR you mentioned.
Just to check, you don't expect these to change ever, right?
Or maybe the goal is to keep the "forbidden binaries" and manually override the check...
Yes.
|
Duplicate of #70817 |
|
@jukkar I need to checking the context of PRs a lot more. 😓
Yes certificates will likely stay the same for the lifetime of the sample. Thank you for helping me catching-up. |
I hope I interpreted @jukkar's comment well:
My bad for missing his former #72804 (comment)
Or maybe the goal is to keep the "forbidden binaries" and manually override the check...