posix: device_io: implement fdopen(), fileno(), pread(), pselect(), pwrite()#73978
Merged
nashif merged 12 commits intozephyrproject-rtos:mainfrom Jun 27, 2024
Merged
posix: device_io: implement fdopen(), fileno(), pread(), pselect(), pwrite()#73978nashif merged 12 commits intozephyrproject-rtos:mainfrom
nashif merged 12 commits intozephyrproject-rtos:mainfrom
Conversation
cfriedt
force-pushed
the
posix-device-io
branch
11 times, most recently
from
e2eba59 to
44a701c
Compare
Member
Author
|
This one has a false positive regarding the reserved word "remove" due to the No changes made there, although it is an ISO C function, and not a POSIX one. That would be a good bugfix at some point. |
4 tasks
cfriedt
force-pushed
the
posix-device-io
branch
5 times, most recently
from
eddd8a3 to
fb66b50
Compare
cfriedt
force-pushed
the
posix-device-io
branch
4 times, most recently
from
677c2f8 to
e3cf1b8
Compare
cfriedt
changed the title
cfriedt
changed the title
cfriedt
force-pushed
the
posix-device-io
branch
2 times, most recently
from
fc608ec to
9a5bb43
Compare
added 8 commits
June 26, 2024 14:45
Move the implementation of zsock_poll to zvfs_poll. This allows other types of file descriptors to also make use of poll() functionality even when the network subsystem is not enabled. Additionally, it partially removes a dependency cycle between posix and networking by moving functionality into a mutual dependency. Signed-off-by: Chris Friedt <[email protected]>
Move the implementation of zsock_select() to zvfs_select(). This allows other types of file descriptors to also make use of select() functionality even when the network subsystem is not enabled. Additionally, it partially removes a dependency cycle between posix and networking by moving functionality into a mutual dependency. Signed-off-by: Chris Friedt <[email protected]>
Implement pselect() as it's required by POSIX_DEVICE_IO Signed-off-by: Chris Friedt <[email protected]>
Implement fdopen(), as required by the POSIX_DEVICE_IO Option Group. Signed-off-by: Chris Friedt <[email protected]>
Implement fileno() as required by the POSIX_DEVICE_IO Option Group. Signed-off-by: Chris Friedt <[email protected]>
Previously, we had only used the flags field and ignored mode with the open() function. Signed-off-by: Chris Friedt <[email protected]>
Mark the POSIX_DEVICE_IO Option Group as commplete. This Option Group is required for PSE51, PSE52, PSE53, PSE54, and most of the interesting applications involving file descriptors and sockets. Signed-off-by: Chris Friedt <[email protected]>
Several help prompts for non-user-selectable Kconfig options included the phrase "select 'y' here", which does not make any sense in this situation. Adjust the help sections to use more appropriate language. Signed-off-by: Chris Friedt <[email protected]>
Member
Author
|
Member
Author
|
Other than the false positive in coding guidelines, this should probably be all green. Please revisit when you have a moment @ycsin, @jukkar, @SeppoTakalo |
ycsin
approved these changes
Jun 27, 2024
jukkar
approved these changes
Jun 27, 2024
aescolar
added a commit
to aescolar/zephyr
that referenced
this pull request
Jul 1, 2024
PR zephyrproject-rtos#73978 introduced a regression. Unfortunately this PR cannot be reverted without reverting also Let's revert both PRs to stabilize main again towards the 3.7 release. For more details on the issue see zephyrproject-rtos#75205 This reverts commit e9b676a. Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar
added a commit
to aescolar/zephyr
that referenced
this pull request
Jul 1, 2024
This reverts commit b18cad1. PR zephyrproject-rtos#73978 introduced a regression. Unfortunately this PR cannot be reverted without reverting also Let's revert both PRs to stabilize main again towards the 3.7 release. For more details on the issue see zephyrproject-rtos#75205 Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar
added a commit
to aescolar/zephyr
that referenced
this pull request
Jul 1, 2024
…iour" This reverts commit b10f1ca. PR zephyrproject-rtos#73978 introduced a regression. Unfortunately this PR cannot be reverted without reverting also Let's revert both PRs to stabilize main again towards the 3.7 release. For more details on the issue see zephyrproject-rtos#75205 Signed-off-by: Alberto Escolar Piedras <[email protected]>
aescolar
added a commit
to aescolar/zephyr
that referenced
this pull request
Jul 1, 2024
…oup" This reverts commit 308322e. PR zephyrproject-rtos#73978 introduced a regression. Unfortunately this PR cannot be reverted without reverting also Let's revert both PRs to stabilize main again towards the 3.7 release. For more details on the issue see zephyrproject-rtos#75205 Signed-off-by: Alberto Escolar Piedras <[email protected]>
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement the remaining functions in the
POSIX_DEVICE_IOOption Group.This Option Group is requried for the PSE51, PSE52, PSE53, and PSE54 subprofiles and likely others.
Doc Preview
Fixes #24966
Fixes #66932
Fixes #66938
Fixes #66946
Fixes #66947
Fixes #66948