Bluetooth: Reshuffle Kconfig options#69
Merged
jhedberg merged 1 commit intozephyrproject-rtos:masterfrom May 4, 2017
Merged
Conversation
nashif
added
the
In progress
jhedberg
reviewed
May 3, 2017
Member
There was a problem hiding this comment.
Just keep the original indent. Going over the 80 char width is a smaller offence than making it look like we're making a function call who's return value we're not storing anywhere (because the call is at the default indent of the function)
Member
There was a problem hiding this comment.
That said, this once again reminds me that we should seriously consider switching to CONFIG_BT_* for Kconfig.
Contributor
There was a problem hiding this comment.
yes, keep the orig indent. Or have the function call in the same line and have the parameter in the next line, indented by a tab.
hci_uart_dev = device_get_binding(
........CONFIG_B);
carlescufi
force-pushed
the
bt_kconfig
branch
2 times, most recently
from
f1b1a5b to
0e59475
Compare
In order to achieve proper sharing of configuration options, everything that is common to both the Host and the Controller should now be placed in the top-level Kconfig file, and Controller-only options are in the controller/ Kconfig one. Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
jhedberg
approved these changes
May 4, 2017
nashif
removed
the
In progress
nagineni
pushed a commit
to nagineni/zephyr
that referenced
this pull request
Nov 20, 2017
[timers] Updated timers to use new callback module
ndrs-pst
added a commit
to DDC-NDRS/zephyr_rtos
that referenced
this pull request
Sep 14, 2025
# Conflicts: # drivers/ethernet/eth_stm32_hal_v2.c # include/zephyr/kernel.h # kernel/msg_q.c
ndrs-pst
added a commit
to DDC-NDRS/zephyr_rtos
that referenced
this pull request
Jan 30, 2026
# Conflicts: # drivers/dma/dma_infineon_pdl.c # drivers/serial/uart_stm32.c # drivers/spi/spi_stm32.c # drivers/spi/spi_stm32.h # subsys/net/ip/tcp.c # west.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to achieve proper sharing of configuration options, everything
that is common to both the Host and the Controller should now be placed
in the top-level Kconfig file, and Controller-only options are in the
controller/ Kconfig one.
Signed-off-by: Carles Cufi carles.cufi@nordicsemi.no