Bluetooth: L2CAP patches tracker - #67511
Closed
jori-nordic wants to merge 8 commits into
Closed
Conversation
jori-nordic
force-pushed
the
l2cap-single-tx-rework
branch
2 times, most recently
from
January 12, 2024 08:07
b906460 to
0789f2b
Compare
If $BASH_SOURCE is the empty string, then those two tests end up with the same simulation ID. That's not a good time. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
It seems like a nice idea at first, but leads to hard-to-debug situations for the application. The previous behavior can be implemented by the app by defining `alloc_seg` and allocating from the same pool as `buf`. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
This simplifies the code. It also saves memory in the metadata structure (`sent` is almost rendered useless), and allows sending buffers that fit MTU without a wasteful segmentation. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
Separate most of the param checking in `bt_l2cap_chan_send()`, with the logic in `bt_l2cap_dyn_chan_send()`. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
Always pull from the channel queue from the system workqueue context. This simplifies debugging. This also allows us to remove `sent` from the metadata struct. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
jori-nordic
force-pushed
the
l2cap-single-tx-rework
branch
from
January 12, 2024 09:02
0789f2b to
517b884
Compare
Remove the logic for adding the SDU length when allocating segments. That section was dead code after the recent patches. Inline the remainder of the logic into `l2cap_chan_le_send()`. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
Fix the handling of buffers with fragments. What seems to have been broken is the metadata reference that was not passed to the next frag in the chain. Add a test to regression too. The main user of this is IPSP. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
They're still subject to change. At least now the users have some idea of what's happening. Signed-off-by: Jonathan Rico <jonathan.rico@nordicsemi.no>
jori-nordic
force-pushed
the
l2cap-single-tx-rework
branch
from
January 12, 2024 09:16
517b884 to
64e127a
Compare
This was referenced Jan 15, 2024
Closed
Contributor
Author
|
all merged 🥳 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to track the patchset replacing #67212
In order:
l2cap_chan_create_seg()#67530bt_l2cap_chan_send()#67532