tests: net: conn_mgr_monitor: increase stack size#62317
Merged
carlescufi merged 1 commit intomainfrom Sep 6, 2023
unknown repository
Merged
tests: net: conn_mgr_monitor: increase stack size#62317carlescufi merged 1 commit intomainfrom unknown repository
carlescufi merged 1 commit intomainfrom
unknown repository
Conversation
Fixes the broken conn_mgr_monitor test. Signed-off-by: Florian Grandel <fgrandel@code-for-humans.de>
ghost
requested review from
ghost
mentioned this pull request
jukkar
approved these changes
Sep 6, 2023
jukkar
added
the
Hotfix
carlescufi
approved these changes
Sep 6, 2023
Contributor
|
Chiming in as requested: LGTM! Thanks for putting it together! The issue, it would seem, was introduced when switching to picolibc: It doesn't seem too strange to me that a change to libc could require adjustments to stack sizes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes (?) the broken conn_mgr_monitor test.
@jukkar @rlubos Not sure whether this is the right way to fix this - the test is however broken on mainline.