net: add winc1500 driver from Atmel by MaxAgneni · Pull Request #60 · zephyrproject-rtos/zephyr

MaxAgneni · 2017-05-03T07:02:20Z

This is part of a patch series to add support for winc1500 wifi module

origin: extracted from Atmel ASF version 3.33.0

was: https://gerrit.zephyrproject.org/r/#/c/12356/

tbursztyka

Where is the NET_DEVICE_INIT or at least DEVICE_INIT?

tbursztyka · 2017-05-03T07:29:10Z

drivers/wifi/Kconfig

change this into a menuconfig WIFI directly

tbursztyka · 2017-05-03T07:30:01Z

drivers/wifi/Kconfig

and you can avoid the prompt by doing: bool "Add support for WiFi drivers"

tbursztyka · 2017-05-03T07:30:18Z

drivers/wifi/Kconfig

and then here you would do:

if WIFI

tbursztyka · 2017-05-03T07:30:35Z

drivers/wifi/Kconfig

and here, instead of endmenu:

endif # WIFI

tbursztyka · 2017-05-03T07:33:24Z

drivers/wifi/winc1500/bsp/include/nm_bsp.h

Sounds like this file should go somewhere in ext/ or?

What goes into all directories but ext, is made for zephyr so there is no such thing as redefining stuff like NULL, uints ... etc... that's useless: Zephyr provides all necessary bits and pieces.

I agree with Tomasz, these changes look like they belong to ext.

I left the function prototypes in this file and moved the other definitions in ext

tbursztyka · 2017-05-03T07:44:28Z

drivers/wifi/winc1500/bsp/source/nm_bsp.c

so no camelcase, but change this to:

K_MS(time_msec) * USEC_PER_SEC

USEC_PER_SEC is found in include/sys_clock.h

tbursztyka · 2017-05-03T07:45:57Z

drivers/wifi/winc1500/bus_wrapper/source/nm_bus_wrapper.c

why redefining this??

tbursztyka · 2017-05-03T07:47:39Z

drivers/wifi/winc1500/bus_wrapper/source/nm_bus_wrapper.c

no need to re-document how spi is configured as all is in spi.h already

removed and configured with spi defines

tbursztyka · 2017-05-03T07:48:19Z

drivers/wifi/winc1500/bus_wrapper/source/nm_bus_wrapper.c

that does not seem to be the case. You are returning -1 in error.

tbursztyka · 2017-05-03T07:48:40Z

drivers/wifi/winc1500/bus_wrapper/source/nm_bus_wrapper.c

80 chars limit.

jukkar

Please have a proper commit messages. So subject, body and signed-off etc.

jukkar · 2017-05-03T08:04:08Z

drivers/wifi/winc1500/bsp/include/nm_bsp_internal.h

No typedefs for structs.

jukkar · 2017-05-03T08:09:26Z

drivers/wifi/winc1500/bsp/include/nm_bsp.h

I agree with Tomasz, these changes look like they belong to ext.

tbursztyka

And please have a proper commit message.

Signed-off-by etc... and we don't care of former gerrit url.

nashif · 2017-05-30T12:31:18Z

boards/x86/panther/Kconfig.defconfig

Remove this, this board does not use NBLE, NBLE is only being used for Arduino 101 with a custom Bluetooth firmware

nashif · 2017-05-30T12:31:41Z

boards/x86/panther/Kconfig.defconfig

remove the whole section above

This part of Kconfig is just removed

nashif · 2017-05-30T12:33:27Z

ext/drivers/atmel/winc1500/Kconfig

everything is commented out here, so what is the point of adding this file?

point to add this file is drivers/wifi/winc1500/Kconfig

but the while thing is commented, so it has no effect at all

in Makefile there is:
obj-$(CONFIG_WIFI_WINC1500) += ....

This is part of a patch series to add support for winc1500 wifi module origin: extracted from Atmel ASF version 3.33.0 Signed-off-by: Massimiliano Agneni <massimiliano.agneni@iptronix.com> Signed-off-by: Anas Nashif <anas.nashif@intel.com> Signed-off-by: Dario Pennisi <dario@iptronix.com>

was: https://gerrit.zephyrproject.org/r/#/c/12365/ Signed-off-by: Massimiliano Agneni <massimiliano.agneni@iptronix.com> Signed-off-by: Anas Nashif <anas.nashif@intel.com> Signed-off-by: Dario Pennisi <dario@iptronix.com>

Signed-off-by: Massimiliano Agneni <massimiliano.agneni@iptronix.com> Signed-off-by: Dario Pennisi <dario@iptronix.com> Signed-off-by: Anas Nashif <anas.nashif@intel.com>

was: https://gerrit.zephyrproject.org/r/#/c/12364/ Signed-off-by: Massimiliano Agneni <massimiliano.agneni@iptronix.com> Signed-off-by: Dario Pennisi <dario@iptronix.com> Signed-off-by: Anas Nashif <anas.nashif@intel.com>

was: https://gerrit.zephyrproject.org/r/#/c/12363/ Signed-off-by: Massimiliano Agneni <massimiliano.agneni@iptronix.com>

drahnr · 2017-09-07T07:26:58Z

Is there a general need for the offload ip stack with this driver? The last commit only removes a couple of dependencies, but not all of them.

galak · 2017-11-03T13:17:33Z

Taken over by #4711

# Conflicts: # drivers/ethernet/eth_stm32_hal_common.c # drivers/ethernet/eth_stm32_hal_priv.h # drivers/sensor/st/stm32_temp/stm32_temp.c # drivers/serial/uart_mcux_lpuart.c # include/zephyr/kernel.h # include/zephyr/kernel/thread.h # samples/net/wifi/shell/prj.conf # subsys/fs/nvs/nvs.c # west.yml

tbursztyka self-requested a review May 3, 2017 07:24

tbursztyka approved these changes May 3, 2017

View reviewed changes

jukkar self-requested a review May 3, 2017 07:51

tbursztyka requested changes May 3, 2017

View reviewed changes

jukkar requested changes May 3, 2017

View reviewed changes

tbursztyka requested changes May 3, 2017

View reviewed changes

jukkar force-pushed the net branch from 6b62d2f to efc6684 Compare May 5, 2017 07:03

MaxAgneni force-pushed the net branch 2 times, most recently from 4980ace to 834c9f2 Compare May 10, 2017 07:16

jukkar added the net label May 15, 2017

nashif changed the base branch from net to master May 30, 2017 11:57

nashif requested changes May 30, 2017

View reviewed changes

MaxAgneni force-pushed the net branch from 834c9f2 to c182b96 Compare June 5, 2017 13:34

nashif force-pushed the net branch 2 times, most recently from 60dfcb1 to 203fdd7 Compare July 4, 2017 00:44

pnndra added 5 commits July 3, 2017 20:48

net: Add zephyr driver for winc1500

fded323

was: https://gerrit.zephyrproject.org/r/#/c/12365/ Signed-off-by: Massimiliano Agneni <massimiliano.agneni@iptronix.com> Signed-off-by: Anas Nashif <anas.nashif@intel.com> Signed-off-by: Dario Pennisi <dario@iptronix.com>

board: panther: Add support for winc1500

df15eaa

Signed-off-by: Massimiliano Agneni <massimiliano.agneni@iptronix.com> Signed-off-by: Dario Pennisi <dario@iptronix.com> Signed-off-by: Anas Nashif <anas.nashif@intel.com>

net: add initial support for wifi management API

08d14ee

was: https://gerrit.zephyrproject.org/r/#/c/12364/ Signed-off-by: Massimiliano Agneni <massimiliano.agneni@iptronix.com> Signed-off-by: Dario Pennisi <dario@iptronix.com> Signed-off-by: Anas Nashif <anas.nashif@intel.com>

net: remove need for l2 on offloaded drivers

075906d

was: https://gerrit.zephyrproject.org/r/#/c/12363/ Signed-off-by: Massimiliano Agneni <massimiliano.agneni@iptronix.com>

nashif force-pushed the net branch from 203fdd7 to 075906d Compare July 4, 2017 00:48

nashif added area: Networking and removed net labels Sep 23, 2017

tbursztyka mentioned this pull request Nov 3, 2017

WINC1500 WiFi module support #4711

Merged

galak closed this Nov 3, 2017

MariuszSkamra mentioned this pull request Jul 15, 2019

L2CAP: On insufficient authentication error received, Zephyr does unauthenticated pairing #17525

Closed

yanzhouy mentioned this pull request Apr 15, 2021

Zephyr build fail with LLVM on Windows #32111

Closed

piotrParf mentioned this pull request Feb 9, 2022

BLE Testing functions do not work properly #42534

Closed

Conversation

MaxAgneni commented May 3, 2017

Uh oh!

tbursztyka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jukkar May 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jukkar left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jukkar May 3, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tbursztyka left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

drahnr commented Sep 7, 2017

Uh oh!

galak commented Nov 3, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jukkar May 3, 2017 •

edited

Loading

jukkar May 3, 2017 •

edited

Loading