Bluetooth: Audio: Fix mcc.c conn logging statements#52429
Merged
carlescufi merged 1 commit intozephyrproject-rtos:mainfrom Nov 22, 2022
Merged
Bluetooth: Audio: Fix mcc.c conn logging statements#52429carlescufi merged 1 commit intozephyrproject-rtos:mainfrom
conn logging statements#52429carlescufi merged 1 commit intozephyrproject-rtos:mainfrom
Conversation
mcc.c does not include `conn_internal.h` so it does not know the `bt_conn` struct, causing logging issues when trying to log a `bt_conn` pointer. Fixed by casting the `conn` pointers to `(void *)`. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>
zephyrbot
requested review from
Casper-Bonde-Bose,
MariuszSkamra and
asbjornsabo
asbjornsabo
approved these changes
Nov 21, 2022
Contributor
|
hmm does %p causes dereference of pointer? (looks kinda odd that it needs to know structure to print pointer) |
Contributor
Author
I honestly don't why it is required (I mean, it's just a pointer value...), but after switching to the new logging system this has been required. The alternative is to include |
alexsven
approved these changes
Nov 22, 2022
kruithofa
approved these changes
Nov 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mcc.c does not include
conn_internal.hso it does not know thebt_connstruct, causing logging issues when trying to log abt_connpointer.Fixed by casting the
connpointers to(void *).Signed-off-by: Emil Gydesen emil.gydesen@nordicsemi.no