Skip to content

net: openthread: Add config for NCP vendor hook#25450

Closed
Philipp-Wohlgenannt-Tridonic-com wants to merge 1 commit intozephyrproject-rtos:masterfrom
tridonic-com:openthread-ncp-vendor-hook
Closed

net: openthread: Add config for NCP vendor hook#25450
Philipp-Wohlgenannt-Tridonic-com wants to merge 1 commit intozephyrproject-rtos:masterfrom
tridonic-com:openthread-ncp-vendor-hook

Conversation

@Philipp-Wohlgenannt-Tridonic-com
Copy link
Copy Markdown

@Philipp-Wohlgenannt-Tridonic-com Philipp-Wohlgenannt-Tridonic-com commented May 19, 2020

Add config for NCP vendor hook.

@zephyrbot
Copy link
Copy Markdown

zephyrbot commented May 19, 2020 •
edited
Loading

All checks are passing now.

Tip: The bot edits this comment instead of posting a new one, so you can check the comment's history to see earlier messages.

Merged
@Philipp-Wohlgenannt-Tridonic-com Philipp-Wohlgenannt-Tridonic-com force-pushed the openthread-ncp-vendor-hook branch 2 times, most recently from f5e97b2 to 7c9b43a Compare May 19, 2020 14:31
rlubos
rlubos reviewed May 21, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update OpenThread revision in the west.yml with a PR reference from OpenThread repository (pull/13/head). Also note that due to feature freeze in Zephyr, this PR may take a while.

@rlubos
Copy link
Copy Markdown
Contributor

rlubos commented May 21, 2020

Also please fix the checkpatch warnings.

@Philipp-Wohlgenannt-Tridonic-com Philipp-Wohlgenannt-Tridonic-com force-pushed the openthread-ncp-vendor-hook branch 4 times, most recently from c445324 to c7a10cb Compare May 26, 2020 08:26
@Philipp-Wohlgenannt-Tridonic-com
Copy link
Copy Markdown
Author

Philipp-Wohlgenannt-Tridonic-com commented May 26, 2020

-:11: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#11: FILE: subsys/net/l2/openthread/Kconfig:269:

  •    depends on OPENTHREAD_NCP$

-:12: WARNING:LEADING_SPACE: please, no spaces at the start of a line
#12: FILE: subsys/net/l2/openthread/Kconfig:270:

  •    help$
  • total: 0 errors, 2 warnings, 18 lines checked

I don't know how to fix this warnings. I don't see any difference to the existing code style. @rlubos what should i do with these 2 warnings?

@rlubos
Copy link
Copy Markdown
Contributor

rlubos commented May 26, 2020

@Philipp-Wohlgenannt-Tridonic-com

All checks are passing now.

It seems to be fine now. The warnings you mention apparently refer to some earlier revision.

@rlubos rlubos added the DNM This PR should not be merged (Do Not Merge) label May 26, 2020
@rlubos
Copy link
Copy Markdown
Contributor

rlubos commented May 26, 2020

DNM until OpenThread is updated

@rlubos
Copy link
Copy Markdown
Contributor

rlubos commented Jun 22, 2020

The OpenThread update and zephyrproject-rtos/openthread#13 were merged, please update SHA: 981b502fc674121fe70ee119de8384acae050f6d

@github-actions github-actions bot added has-conflicts Issue/PR has conflicts with another issue/PR and removed has-conflicts Issue/PR has conflicts with another issue/PR labels Jun 29, 2020
@zephyrbot zephyrbot removed the has-conflicts Issue/PR has conflicts with another issue/PR label Jul 7, 2020
@rlubos rlubos mentioned this pull request Jul 13, 2020
Open
@kkasperczyk-no
Copy link
Copy Markdown
Contributor

kkasperczyk-no commented Jul 13, 2020

@Philipp-Wohlgenannt-Tridonic-com are you planning to make any further activities connected with this pull request and inserting changes stated by @rlubos? I'm interested in inserting the same changes, as you did in your commit.

@markus-becker-tridonic-com
Copy link
Copy Markdown
Contributor

markus-becker-tridonic-com commented Jul 14, 2020

@Philipp-Wohlgenannt-Tridonic-com are you planning to make any further activities connected with this pull request and inserting changes stated by @rlubos? I'm interested in inserting the same changes, as you did in your commit.

@Philipp-Wohlgenannt-Tridonic-com will be back in office towards end of the month.

@Philipp-Wohlgenannt-Tridonic-com
net: openthread: Add NCP vendor hook
83ec3f4 
Add NCP vendor hook for vendor sepcific code

Signed-off-by: Philipp Wohlgenannt <[email protected]>
@rlubos
Copy link
Copy Markdown
Contributor

rlubos commented Jul 27, 2020

@Philipp-Wohlgenannt-Tridonic-com The west.yml is already up to date, and OPENTHREAD_NCP_VENDOR_HOOK_SOURCE was added in some other PR, I think we can close this one.

@Philipp-Wohlgenannt-Tridonic-com
Copy link
Copy Markdown
Author

Philipp-Wohlgenannt-Tridonic-com commented Jul 27, 2020 •
edited
Loading

@Philipp-Wohlgenannt-Tridonic-com The west.yml is already up to date, and OPENTHREAD_NCP_VENDOR_HOOK_SOURCE was added in some other PR, I think we can close this one.

Yes we can close this request. @rlubos can you do that?

@rlubos
Copy link
Copy Markdown
Contributor

rlubos commented Jul 27, 2020

Sure, thanks!

@rlubos rlubos closed this Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tbursztyka tbursztyka tbursztyka approved these changes

@rlubos rlubos rlubos approved these changes

Assignees

No one assigned

Labels

area: Modules area: Networking DNM This PR should not be merged (Do Not Merge)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Philipp-Wohlgenannt-Tridonic-com @zephyrbot @rlubos @kkasperczyk-no @markus-becker-tridonic-com @tbursztyka