Skip to content

tests:kernel: added tests for printk left justifier#25

Merged
nashif merged 1 commit intozephyrproject-rtos:masterfrom
sharronliu:tests_v1.8
May 8, 2017
Merged

tests:kernel: added tests for printk left justifier#25
nashif merged 1 commit intozephyrproject-rtos:masterfrom
sharronliu:tests_v1.8

Conversation

@sharronliu
Copy link
Copy Markdown

@sharronliu sharronliu commented May 1, 2017

Added test case for printk the '-' indicator in format string (left justifier).

Jira: ZEP-1599

Signed-off-by: Sharron LIU sharron.liu@intel.com


This change is Reviewable

@nashif nashif self-assigned this May 1, 2017
"%u %02u %04u %08u\n", 42, 42, 42, 42);

count += snprintk(ram_console + count, sizeof(ram_console) - count,
"%-8u%-6d%-4x%-2p%8d\n",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the %-2p doesn't seem to work as intended as it's still printing: 0x00000042, was it supposed to print "0x42" instead?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. You're right, prefix '0' should be unexpected. Thanks.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failure tracked as ZEP-2102

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ZEP-2102 has been justified by developer.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with @lpereira, lets adapt the test, making printk always behave as printf is a none goal, printk is a custom version that needs to be small and usable on the smallest of devices.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests adapted.

@sharronliu sharronliu force-pushed the tests_v1.8 branch 3 times, most recently from d97ad9c to 262e17f Compare May 8, 2017 05:00
Added test case for printk the '-' indicator in format string
(left justifier).

Jira: ZEP-1599

Signed-off-by: Sharron LIU <sharron.liu@intel.com>
@nashif nashif merged commit 6c6182d into zephyrproject-rtos:master May 8, 2017
nagineni pushed a commit to nagineni/zephyr that referenced this pull request Nov 20, 2017
[BLE] Add missing flags arg to fix compile warning on write callback
rettichschnidi added a commit to rettichschnidi/zephyr that referenced this pull request Mar 6, 2018
According to STM32-E407.pdf (Revision I, June 2017), CON1 RST is
connected to processor pin zephyrproject-rtos#25, not zephyrproject-rtos#23.

Signed-off-by: Reto Schneider <code@reto-schneider.ch>
galak pushed a commit that referenced this pull request Mar 6, 2018
According to STM32-E407.pdf (Revision I, June 2017), CON1 RST is
connected to processor pin #25, not #23.

Signed-off-by: Reto Schneider <code@reto-schneider.ch>
frasa pushed a commit to blik-GmbH/zephyr that referenced this pull request Mar 25, 2019
* Configure automatic enable of SPI if Flash is selected
* Corrected SPI Flash frequency option by removing the `CONFIG_` prefix

Relates to zephyrproject-rtos#25
frasa pushed a commit to blik-GmbH/zephyr that referenced this pull request Mar 25, 2019
* Ports the board support of the Akita Gen2 development board to the
Akita Gen2 production board.

Signed-Off-By: Alexander Preißner <alexander.preissner@blik.io>

Closes zephyrproject-rtos#25
frasa pushed a commit to blik-GmbH/zephyr that referenced this pull request Mar 25, 2019
* Replaced all spaces with tabs to conform with Zephyr style guide

Signed-Off-By: Alexander Preißner <alexander.preissner@blik.io>

Closes zephyrproject-rtos#25
frasa added a commit to blik-GmbH/zephyr that referenced this pull request Mar 25, 2019
Fix: full device config support BSP

Closes zephyrproject-rtos#25

See merge request blik/embedded/zephyr!31
MuhammedZamroodh pushed a commit to Zephyr4Microchip/zephyr that referenced this pull request Aug 5, 2025
)

Added the timer driver for microchip's dspic33ak128mc106.

Signed-off-by: Udhayanandhan Jayakumar <udhayanandhan.jayakumar@ignitarium.com>
ndrs-pst added a commit to DDC-NDRS/zephyr_rtos that referenced this pull request Dec 15, 2025
# Conflicts:
#	drivers/counter/CMakeLists.txt
#	drivers/serial/uart_esp32.c
#	include/zephyr/arch/arch_interface.h
#	lib/os/reboot.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants