Native POSIX Flash support by vanwinkeljan · Pull Request #12503 · zephyrproject-rtos/zephyr

vanwinkeljan · 2019-01-16T00:04:41Z

This PR adds flash support for the Native POSIX target, the flash data is placed on a binary file on the host system. ~~Further the PR provides the possibility to access FS partition on the flash by means of FUSE file system mounted on a host directory~~

Following features were included in this PR either to make it functional or to test it:

DTS support for Native POSIX
Updated test cases that require a flash but where not covered by QEMU
~~Updated sanitycheck run directory~~
~~Extended FS API to read mount points~~
~~Added FS Shell Sample~~

This PR cover flash part mentioned in issue #6044

FUSE support will be moved to separate PR
Moved sanitycheck changes to PR #16149

zephyrbot · 2019-01-16T00:06:34Z

All checks are passing now.

Review history of this comment for details about previous failed status.
Note that some checks might have not completed yet.

aescolar

This will take a while to review.. Some minor things after a quick look thru

boards/posix/native_posix/Kconfig

boards/posix/native_posix/native_posix.dts

boards/posix/native_posix/doc/board.rst

aescolar

a few more

boards/posix/native_posix/doc/board.rst

aescolar · 2019-01-16T15:15:58Z

boards/posix/native_posix/fuse_flash.c

After a quick look it would seem this file is not really part of the native_posix board, but could be shared by any posix arch based board, and could therefore have been anywhere else(?). If that is the case maybe it would be nicer to place it with the flash driver itself(?)
(The Kconfig option and cmake paragraph would go with it)

Good point but would it not be better to move it then to subsys/fs?

I have no opinion, I think it would be best if one of the flash or fs maintainers would comment here.

^^^ @nashif @ramakrishnapallala

boards/posix/native_posix/doc/board.rst

boards/posix/native_posix/fuse_flash.c

boards/posix/native_posix/doc/board.rst

dts/bindings/posix/zephyr,posix.yaml

subsys/settings/src/settings_file.c

tests/subsys/dfu/mcuboot/src/main.c

boards/posix/native_posix/doc/board.rst

samples/subsys/fs/shell/README.rst

boards/posix/native_posix/doc/board.rst

aescolar

I have no experience or knowledge about DTS or the filesystem part, so somebody else will need to review those.
@galak Would you do the honors for the DTS part? (or both)

aescolar · 2019-01-26T16:05:14Z

boards/posix/native_posix/native_posix.dts

+		reg = <0x00000000 DT_SIZE_K(2048)>;
+
+		partitions {
+			compatible = "fixed-partitions";


It really feels a bit funny to define partitions or the flash size in a file for the native_posix board, when it could have any size the developer would want to test with. Maybe somebody who know more about DTS (@galak) could comment here?

You should see it more as a default config the developer can overrule any of the DST values in a overlay.

boards/posix/native_posix/doc/board.rst

drivers/flash/Kconfig.native_posix

boards/posix/native_posix/native_posix.dts

drivers/flash/flash_native_posix.c

boards/posix/native_posix/fuse_flash.c

samples/subsys/fs/shell/README.rst

aescolar · 2019-01-26T18:25:40Z

samples/subsys/fs/shell/README.rst

+Ls
+--
+
+List all files and directories in a given path


I have no experience with the filesystem subsystem, but I can't even get to list an empty mount point.

uart:~$ fs mount nffs /nffs Successfully mounted fs:/nffs uart:~$ fs ls /nffs Unable to open /nffs (err -22)

or to mess with it from the FUSE mount side. I wonder if that's me or something is broken.

It is not you, I did hit the same issue.
After looking through the FS code it seems that it is limitation in Zephyrs FS implementation it seems that current implementation expects the root slash.

So fs ls /nffs/ should do the trick, btw I did put a workaround in the Fuse code to handle this case.

dbkinder

+1 for docs, thanks!

jhedberg · 2019-04-09T09:47:51Z

Any update on this PR?

aescolar · 2019-04-09T10:30:31Z

@galak @nvlsianpu : Could you please review the DTS and file system sides respectively?

Pending review by FS and DTS maintainers, the native_posix part was ok to the best of my recolection

galak

Sorry if I didn't mention this before, but can you pull the 'sanitycheck: Execute binary in output directory' commit into its own PR.

galak · 2019-05-14T11:26:10Z

LGTM.

vanwinkeljan · 2019-05-14T11:41:51Z

@galak

Sorry if I didn't mention this before, but can you pull the 'sanitycheck: Execute binary in output directory' commit into its own PR.

Sorry my misunderstanding; I just split the PR in two, flash support and fuse access support.
I will move the sanitycheck commit in another PR, of course this PR will be blocked until it is merged and the commit will stay visible in this PR.

aescolar

No complaints from me (note I did not retest it). But again, somebody who knows more about the flash side of things needs to give his opinion.
Just one request: Please add yourself also as codeowner to drivers/flash/*native_posix*
(Otherwise you could be sure I would be adding you to any review or bug for these files :) )

vanwinkeljan · 2019-05-14T17:30:19Z

Just one request: Please add yourself also as codeowner to drivers/flash/native_posix

Done

Sorry if I didn't mention this before, but can you pull the 'sanitycheck: Execute binary in output directory' commit into its own PR.

Done

vanwinkeljan · 2019-05-14T17:31:34Z

Added DNM label as this PR depends on #16149

CODEOWNERS

Added device tree support for POSIX architecture based boards. Signed-off-by: Jan Van Winkel <[email protected]>

Added native POSIX flash driver that writes flash content to a binary file. Signed-off-by: Jan Van Winkel <[email protected]>

Added native POSIX boards as target for flash related tests. Signed-off-by: Jan Van Winkel <[email protected]>

addressed

aescolar

I guess it is unlikely to get more reviews, so I think we can get this in, there is nothing wrong to me. (There would be just 1 nit: The 2nd UART being described in DTS for consistency, but it can come later)

vanwinkeljan requested review from aescolar, andrewboie, dbkinder, nashif and ramakrishnapallala as code owners January 16, 2019 00:04

vanwinkeljan added area: Flash area: native port Host native arch port (native_sim) labels Jan 16, 2019

vanwinkeljan force-pushed the flash_native_posix branch from b27006e to 53b17ac Compare January 16, 2019 07:35

vanwinkeljan assigned galak and unassigned galak Jan 16, 2019

vanwinkeljan requested a review from galak January 16, 2019 07:52

aescolar requested changes Jan 16, 2019

View reviewed changes

boards/posix/native_posix/Kconfig Outdated Show resolved Hide resolved

boards/posix/native_posix/native_posix.dts Outdated Show resolved Hide resolved

boards/posix/native_posix/doc/board.rst Outdated Show resolved Hide resolved

aescolar added Maintainer Enhancement Changes/Updates/Additions to existing features labels Jan 16, 2019

aescolar requested changes Jan 16, 2019

View reviewed changes

dbkinder suggested changes Jan 17, 2019

View reviewed changes

vanwinkeljan force-pushed the flash_native_posix branch 2 times, most recently from 651f674 to 1df6f1d Compare January 21, 2019 21:59

aescolar previously requested changes Jan 26, 2019

View reviewed changes

vanwinkeljan force-pushed the flash_native_posix branch 3 times, most recently from 8301c70 to 3a974b9 Compare February 1, 2019 17:33

vanwinkeljan force-pushed the flash_native_posix branch from 3a974b9 to 511556b Compare February 15, 2019 18:22

dbkinder approved these changes Feb 19, 2019

View reviewed changes

vanwinkeljan force-pushed the flash_native_posix branch from 511556b to ee09fc5 Compare March 12, 2019 19:41

vanwinkeljan requested a review from nvlsianpu as a code owner March 12, 2019 19:41

vanwinkeljan requested review from aescolar and galak May 13, 2019 19:30

zephyrproject-rtos deleted a comment from codecov-io May 14, 2019

galak previously requested changes May 14, 2019

View reviewed changes

aescolar reviewed May 14, 2019

View reviewed changes

vanwinkeljan mentioned this pull request May 14, 2019

sanitycheck: Execute binary in output directory #16149

Merged

vanwinkeljan force-pushed the flash_native_posix branch 2 times, most recently from 92acbaa to fe793c6 Compare May 14, 2019 17:28

vanwinkeljan added the DNM This PR should not be merged (Do Not Merge) label May 14, 2019

aescolar reviewed May 14, 2019

View reviewed changes

CODEOWNERS Outdated Show resolved Hide resolved

aescolar requested a review from galak May 14, 2019 17:35

vanwinkeljan force-pushed the flash_native_posix branch 2 times, most recently from e96e76e to 0ff64d9 Compare May 16, 2019 06:37

vanwinkeljan force-pushed the flash_native_posix branch from 0ff64d9 to c9488bc Compare May 23, 2019 13:29

vanwinkeljan removed the DNM This PR should not be merged (Do Not Merge) label May 23, 2019

vanwinkeljan force-pushed the flash_native_posix branch from c9488bc to 947b1cb Compare May 24, 2019 09:53

vanwinkeljan added 3 commits May 28, 2019 18:49

dts: posix: Add DTS support for POSIX architecture

3f0d3cb

Added device tree support for POSIX architecture based boards. Signed-off-by: Jan Van Winkel <[email protected]>

drivers: flash: Added native POSIX flash driver

d9846dc

Added native POSIX flash driver that writes flash content to a binary file. Signed-off-by: Jan Van Winkel <[email protected]>

tests: Added native POSIX to flash based tests

efec595

Added native POSIX boards as target for flash related tests. Signed-off-by: Jan Van Winkel <[email protected]>

vanwinkeljan force-pushed the flash_native_posix branch from 947b1cb to efec595 Compare May 28, 2019 16:49

nashif approved these changes May 28, 2019

View reviewed changes

aescolar approved these changes May 28, 2019

View reviewed changes

nashif merged commit afdbc20 into zephyrproject-rtos:master May 29, 2019

vanwinkeljan deleted the flash_native_posix branch May 29, 2019 07:03

vanwinkeljan mentioned this pull request May 29, 2019

Added support to access native posix flash via host file system #16467

Merged

Conversation

vanwinkeljan commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zephyrbot commented Jan 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aescolar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aescolar left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aescolar Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

vanwinkeljan Jan 16, 2019

Choose a reason for hiding this comment

Uh oh!

aescolar Jan 26, 2019

Choose a reason for hiding this comment

Uh oh!

vanwinkeljan Jan 27, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aescolar left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aescolar Jan 26, 2019

Choose a reason for hiding this comment

Uh oh!

vanwinkeljan Jan 26, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aescolar Jan 26, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vanwinkeljan Jan 26, 2019

Choose a reason for hiding this comment

Uh oh!

dbkinder left a comment

Choose a reason for hiding this comment

Uh oh!

jhedberg commented Apr 9, 2019

Uh oh!

aescolar commented Apr 9, 2019

Uh oh!

galak left a comment

Choose a reason for hiding this comment

Uh oh!

vanwinkeljan commented Jan 16, 2019 •

edited

Loading

zephyrbot commented Jan 16, 2019 •

edited

Loading

aescolar left a comment •

edited

Loading

aescolar Jan 26, 2019 •

edited

Loading

aescolar left a comment •

edited

Loading

aescolar left a comment •

edited

Loading