mcux-sdk-ng: enet: fsl_enet: avoid possible race condition on timestamp #554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only correct second value if the nanosecond has reasonably value. Signed-off-by: Adib Taraben <[email protected]>
theadib
force-pushed
the
fsl_enet_second_correction
branch
from
d3517ed to
e980603
Compare
Collaborator
|
@theadib , thank you for your change. Please also submit a PR to this repo: https://github.com/nxp-mcuxpresso/mcux-sdk |
Contributor
Author
|
Hello @mmahadevan108 I have done the same PR to the mcux-sdk |
Collaborator
|
Thank you and apologies for pointing you to an older repo. Can you resubmit your PR to this repo: nxp-mcuxpresso/mcuxsdk-core |
Collaborator
|
Once merged into the SDK repo then we can take this change here as we do not have to worry about losing this fix during SDK updates in the HAL. |
Contributor
Author
|
done PR in mcuxsdk-core as well nxp-mcuxpresso/mcuxsdk-core#4 |
mmahadevan108
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only correct second value if the nanosecond has reasonably value.
If the overflow happen short after the capture of the timestamp,
but before checking the ISR flag,
then the second value is corrected falsely.
The patch applies for the FRDM_K64F board having K64 family.