Skip to content

chore: support Symfony 8 #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kbond merged 2 commits into from
Jan 8, 2026
Merged

chore: support Symfony 8 #184

kbond merged 2 commits into from
Jan 8, 2026
+86 −176

Conversation

@nikophil
Copy link
Member

@nikophil nikophil commented Nov 2, 2025 •
edited by kbond
Loading

fixes #183

this would need zenstruck/.github#5 in order to be tested on SF 8

Blockers:

@nikophil nikophil force-pushed the chore/sf-8 branch 4 times, most recently from 0a5e726 to 08cff55 Compare November 9, 2025 16:14
nikophil
nikophil commented Nov 9, 2025
View reviewed changes
nikophil
nikophil commented Nov 9, 2025
View reviewed changes
@nikophil nikophil force-pushed the chore/sf-8 branch 2 times, most recently from 5e3ef4d to 0b0b256 Compare November 9, 2025 16:27
@Chris53897
Copy link
Contributor

Chris53897 commented Nov 28, 2025

symfony/panther does now allow symfony 8 with 2.3.0
https://packagist.org/packages/symfony/panther#v2.3.0

@Kocal
Copy link

Kocal commented Nov 28, 2025

Yes, symfony/panther#678 is open

@nikophil
Copy link
Member Author

nikophil commented Nov 28, 2025

@Chris53897 yes I'm going to finish this soon

@Kocal I don't understand the PR you linked: Panther seems to already support SF 8?

@Kocal
Copy link

Kocal commented Nov 28, 2025

More or less, some minor things are missing for truly Symfony 8 compatibility

@nikophil nikophil force-pushed the chore/sf-8 branch 2 times, most recently from 45272e4 to 751c3a2 Compare November 29, 2025 12:01
@nikophil
Copy link
Member Author

nikophil commented Nov 29, 2025 •
edited
Loading

I just realized that symfony/panther still does not accept symfony/http-client 8

we're definitely stuck waiting for symfony/panther#678 to be merged

@Kocal
Copy link

Kocal commented Dec 6, 2025

.. and Panther is waiting for php-webdriver/php-webdriver#1134 to be merged/released :D

This was referenced Dec 6, 2025
Merged
Merged
@tacman
Copy link

tacman commented Dec 12, 2025

What about creating a release without panther support? That way the Kernel-based browsing would work with Symfony 8.

@tacman tacman mentioned this pull request Jan 2, 2026
Merged
@Chris53897
Copy link
Contributor

Chris53897 commented Jan 8, 2026

@nikophil Could you please re-run ci. Now after the new release of panther with full symfony 8 support.

@kbond
Copy link
Member

kbond commented Jan 8, 2026

On it!

@Kocal
Copy link

Kocal commented Jan 8, 2026

Can't wait to see UX's CI more green 🤩

@kbond kbond force-pushed the chore/sf-8 branch 2 times, most recently from da05bdb to 96aa7de Compare January 8, 2026 14:56
@kbond kbond merged commit 9d7dbe9 into zenstruck:1.x Jan 8, 2026
16 checks passed
@kbond
Copy link
Member

kbond commented Jan 8, 2026

Done and released! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kbond kbond kbond left review comments

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support Symfony 8

5 participants

@nikophil @Chris53897 @Kocal @tacman @kbond