fix(delegate): update with "connect" is not properly rejected for polymorphic models

[ymc9]

Fixes #1674

[coderabbitai]

Walkthrough

Walkthrough

The changes introduce modifications to the getBackLink function in the model-meta-generator.ts file, enhancing its handling of polymorphic scenarios. Additionally, new test cases are added to validate access control policies in a Prisma schema, ensuring that operations involving polymorphic models and their connections adhere to defined permissions.

Changes

Files	Change Summary
packages/sdk/src/model-meta-generator.ts	Updated getBackLink function to use a conditional assignment for sourceModel to handle polymorphism.
tests/integration/tests/enhancements/with-delegate/policy-interaction.test.ts	Added a test case to verify access control for creating and updating RatedPost and Post with comments.
tests/regression/tests/issue-1674.test.ts	Introduced a regression test for issue 1674 to validate access control on creating PostA associated with a blog.

Assessment against linked issues

Objective	Addressed	Explanation
[Delegate] entities can be connected to a polymorphic model even without update permissions (#1674)	✅

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between e4e9fbf and 9f2fd25.

Files selected for processing (3)

• packages/sdk/src/model-meta-generator.ts (1 hunks)
• tests/integration/tests/enhancements/with-delegate/policy-interaction.test.ts (1 hunks)
• tests/regression/tests/issue-1674.test.ts (1 hunks)

Additional comments not posted (6)

tests/regression/tests/issue-1674.test.ts (4)

1-1: Approved import statement.

The import of loadSchema from @zenstackhq/testtools is essential for setting up the test environment.

---

2-2: Clear and concise test suite setup.

The test suite is appropriately named after the issue it addresses, enhancing traceability and clarity.

---

3-56: Well-structured test case setup.

The asynchronous test case properly sets up the environment using loadSchema, which is crucial for accurately testing the permissions and relations defined in the schema.

---

59-85: Test logic aligns well with PR objectives.

The test effectively simulates the scenario described in the issue, where a PostA instance attempts to connect to a Blog without the necessary permissions. The use of toBeRejectedByPolicy appropriately tests the enforcement of access control policies.

tests/integration/tests/enhancements/with-delegate/policy-interaction.test.ts (1)

212-270: Comprehensive test case for policy interaction.

The test case is well-structured and effectively tests the enforcement of policies during connect operations. The schema setup and the use of toBeRejectedByPolicy and toResolveTruthy assertions are appropriate for verifying that the policies are correctly applied based on user permissions.

packages/sdk/src/model-meta-generator.ts (1)

301-302: Enhanced handling of polymorphic models in getBackLink.

The use of the nullish coalescing operator to determine the sourceModel based on field.$inheritedFrom is a robust solution for handling polymorphic scenarios. This ensures that the correct base model is used, which is crucial for maintaining the integrity of model relationships.