Skip to content

fix(zod): generate optional field as z.optional() rather than z.nullish() to be consistent with Prisma's typing #1426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ymc9 merged 2 commits into from
May 9, 2024
Merged

fix(zod): generate optional field as z.optional() rather than z.nullish() to be consistent with Prisma's typing #1426

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17e91fe
fix(zod): generate optional field as `z.optional()` rather than `z.nu…
ymc9 May 9, 2024
4de48c1
retry fix
ymc9 May 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/schema/src/plugins/zod/utils/schema-gen.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,15 +144,15 @@ export function makeFieldSchema(field: DataModelField) {
// field uses `auth()` in `@default()`, this was transformed into a pseudo default
// value, while compiling to zod we should turn it into an optional field instead
// of `.default()`
schema += '.nullish()';
schema += '.optional()';
} else {
const schemaDefault = getFieldSchemaDefault(field);
if (schemaDefault !== undefined) {
schema += `.default(${schemaDefault})`;
}

if (field.type.optional) {
schema += '.nullish()';
schema += '.optional()';
}
}

Expand Down