-
Notifications
You must be signed in to change notification settings - Fork 2
EvaluationStar|Add EvaluationStar Specification #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
quqjp
wants to merge
8
commits into
main
Choose a base branch
from
vk/ff50-evaluationstar
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `docs/component/evaluation-star-specification.md:1` に EvaluationStar の仕様書を新規作成し、Props/状態/使用例/アクセシビリティ/注意事項/更新履歴をテンプレ順に整備しました(更新履歴はJST表記で記載)。 - `packages/component-ui/src/evaluation-star/Docs.mdx:1` で仕様書の埋め込み・Code Examples セクションを追加し、Storybook Docs から詳細仕様とサンプルコードを参照できるようにしました。 - `packages/component-ui/src/evaluation-star/evaluation-star.tsx:6` に Props 説明コメントを付与し、各プロパティの役割とデフォルト挙動をソース上で把握しやすくしました。 - `README.md:133` のコンポーネント一覧に Evaluation Star 仕様書へのリンクを追加し、索引から直接参照できるようにしました。 **テスト** - 未実施(ドキュメントとコメントのみの変更のため) 必要に応じて `yarn storybook` で Docs.mdx の表示を確認してください。
Chromatic resultsOutputs
|
6652ed0 to
6a2439d
Compare
- `docs/component/evaluation-star-specification.md:1` に EvaluationStar の仕様書を新規作成し、Props/状態/使用例/アクセシビリティ/注意事項/更新履歴をテンプレ順に整備しました(更新履歴はJST表記で記載)。 - `packages/component-ui/src/evaluation-star/Docs.mdx:1` で仕様書の埋め込み・Code Examples セクションを追加し、Storybook Docs から詳細仕様とサンプルコードを参照できるようにしました。 - `packages/component-ui/src/evaluation-star/evaluation-star.tsx:6` に Props 説明コメントを付与し、各プロパティの役割とデフォルト挙動をソース上で把握しやすくしました。 - `README.md:133` のコンポーネント一覧に Evaluation Star 仕様書へのリンクを追加し、索引から直接参照できるようにしました。 **テスト** - 未実施(ドキュメントとコメントのみの変更のため) 必要に応じて `yarn storybook` で Docs.mdx の表示を確認してください。
This reverts commit bf853f8.
6ad67ca to
a7e7b95
Compare
…-component into vk/ff50-evaluationstar
This reverts commit 6652ed0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
変更内容