feat(container-menu)!: Add getAnchorProps for explicit anchor handling

[ze-flo]

Description

This PR updates the useMenu API by decoupling anchor-related logic from getItemProps. It introduces a new getAnchorProps getter for handling anchor-specific attributes in navigational menus. This PR is to supersede #693.

BREAKING CHANGES

• getItemProps no longer includes anchor-related props. Use getAnchorProps for <a> tags.
• Continue using getItemProps for <li>-level attributes around anchor items.
• useMenu no longer tracks selected link state internally. Consumers must now:
  • Mark items as selected by default with selected: true, or
  • Use props.selectedItems (overrides items selected by default)

Details

getAnchorProps behavior:

• Returns anchor attributes (href, target, rel, etc.) for items with an href.
• Adds target="_blank" and rel="noreferrer noopener" when external is true.
• Omits anchor attributes for disabled items.
• Disables interactions (click, keydown) for selected anchors.
• Enforces a single selected anchor per menu.

See zendeskgarden/react-components#2019 for implementation preview in Menu.

Checklist

• 🌐 demo is up-to-date (npm start)
• 💂‍♂️ includes new unit tests
• ♿ tested for WCAG 2.1 AA compliance
• 📝 tested in Chrome, Firefox, Safari, and Edge

[coveralls]

coverage: 94.884% (-0.05%) from 94.934%
when pulling a93b7d3 on ze-flo/menu-get-anchor-props
into a79dac8 on main.

[jzempel]

useMenu no longer tracks selected link state internally. Consumers must now...

How does this impact react-components with respect to a breaking change?

[jzempel]

[nit] prefer import { useEffect } from 'react'; similar to useRef above

[ze-flo]

useMenu no longer tracks selected link state internally. Consumers must now...

How does this impact react-components with respect to a breaking change?

No impact. The PR introducing navigational menu items was never merged. 😌

[jzempel]

From the story deployment, it appears I can set initial selected to true for the anchor item in the uncontrolled demo. But the same does not appear to be true for the controlled demo: https://68224a63b85f0898b77419aa--zendeskgarden-react-containers.netlify.app/?path=/story/packages-menu--controlled&args=items[4].external:!true;items[4].selected:!true;isExpanded:!true;focusedValue:plant-04

[ze-flo]

https://68224a63b85f0898b77419aa--zendeskgarden-react-containers.netlify.app/?path=/story/packages-menu--controlled&args=items[4].external:!true;items[4].selected:!true;isExpanded:!true;focusedValue:plant-04

This spec tests that use-case.

selectedItems overrides any default selected items. Removing the selectedItems control shows the anchor as selected.

Note: By design, default selected items are only applied on initial mount. Subsequent changes to the items array won't affect the selection. If you're updating default selections and selectedItems is set to null, make sure to rerun the story to see the changes.

[jzempel]

Thanks for the clarification. LGTM